Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <[email protected]>
Suggested-by: Luis Chamberlain <[email protected]>
Cc: Luis Chamberlain <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Hitomi Hasegawa <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: Lee Jones <[email protected]>
---
drivers/mfd/intel_soc_pmic_crc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
index b1548a933dc3..b745ace46e5b 100644
--- a/drivers/mfd/intel_soc_pmic_crc.c
+++ b/drivers/mfd/intel_soc_pmic_crc.c
@@ -271,6 +271,5 @@ static struct i2c_driver crystal_cove_i2c_driver = {
module_i2c_driver(crystal_cove_i2c_driver);
MODULE_DESCRIPTION("I2C driver for Intel SoC PMIC");
-MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Yang, Bin <[email protected]>");
MODULE_AUTHOR("Zhu, Lejun <[email protected]>");
--
2.39.1.268.g9de2f9a303
On Fri, Feb 24, 2023 at 03:07:48PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <[email protected]>
> Suggested-by: Luis Chamberlain <[email protected]>
> Cc: Luis Chamberlain <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: Hitomi Hasegawa <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Lee Jones <[email protected]>
Please, use --cc parameter instead of polluting commit message.
With this addressed,
Reviewed-by: Andy Shevchenko <[email protected]>
> diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
> index b1548a933dc3..b745ace46e5b 100644
> --- a/drivers/mfd/intel_soc_pmic_crc.c
> +++ b/drivers/mfd/intel_soc_pmic_crc.c
> @@ -271,6 +271,5 @@ static struct i2c_driver crystal_cove_i2c_driver = {
> module_i2c_driver(crystal_cove_i2c_driver);
>
> MODULE_DESCRIPTION("I2C driver for Intel SoC PMIC");
> -MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Yang, Bin <[email protected]>");
> MODULE_AUTHOR("Zhu, Lejun <[email protected]>");
--
With Best Regards,
Andy Shevchenko
On Fri, 24 Feb 2023, Andy Shevchenko wrote:
> On Fri, Feb 24, 2023 at 03:07:48PM +0000, Nick Alcock wrote:
> > Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> > are used to identify modules. As a consequence, uses of the macro
> > in non-modules will cause modprobe to misidentify their containing
> > object file as a module when it is not (false positives), and modprobe
> > might succeed rather than failing with a suitable error message.
> >
> > So remove it in the files in this commit, none of which can be built as
> > modules.
> >
> > Signed-off-by: Nick Alcock <[email protected]>
> > Suggested-by: Luis Chamberlain <[email protected]>
>
> > Cc: Luis Chamberlain <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: Hitomi Hasegawa <[email protected]>
> > Cc: Andy Shevchenko <[email protected]>
> > Cc: Lee Jones <[email protected]>
>
> Please, use --cc parameter instead of polluting commit message.
I personally use this a lot. It's better for scripting.
It's okay, I will remove this when applying.
> With this addressed,
> Reviewed-by: Andy Shevchenko <[email protected]>
>
> > diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
> > index b1548a933dc3..b745ace46e5b 100644
> > --- a/drivers/mfd/intel_soc_pmic_crc.c
> > +++ b/drivers/mfd/intel_soc_pmic_crc.c
> > @@ -271,6 +271,5 @@ static struct i2c_driver crystal_cove_i2c_driver = {
> > module_i2c_driver(crystal_cove_i2c_driver);
> >
> > MODULE_DESCRIPTION("I2C driver for Intel SoC PMIC");
> > -MODULE_LICENSE("GPL v2");
> > MODULE_AUTHOR("Yang, Bin <[email protected]>");
> > MODULE_AUTHOR("Zhu, Lejun <[email protected]>");
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
--
Lee Jones [李琼斯]
On Fri, 24 Feb 2023, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <[email protected]>
> Suggested-by: Luis Chamberlain <[email protected]>
> Cc: Luis Chamberlain <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: Hitomi Hasegawa <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Lee Jones <[email protected]>
> ---
> drivers/mfd/intel_soc_pmic_crc.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
On 3 Mar 2023, Lee Jones spake thusly:
> On Fri, 24 Feb 2023, Andy Shevchenko wrote:
>
>> On Fri, Feb 24, 2023 at 03:07:48PM +0000, Nick Alcock wrote:
>> > Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> > are used to identify modules. As a consequence, uses of the macro
>> > in non-modules will cause modprobe to misidentify their containing
>> > object file as a module when it is not (false positives), and modprobe
>> > might succeed rather than failing with a suitable error message.
>> >
>> > So remove it in the files in this commit, none of which can be built as
>> > modules.
>> >
>> > Signed-off-by: Nick Alcock <[email protected]>
>> > Suggested-by: Luis Chamberlain <[email protected]>
>>
>> > Cc: Luis Chamberlain <[email protected]>
>> > Cc: [email protected]
>> > Cc: [email protected]
>> > Cc: Hitomi Hasegawa <[email protected]>
>> > Cc: Andy Shevchenko <[email protected]>
>> > Cc: Lee Jones <[email protected]>
>>
>> Please, use --cc parameter instead of polluting commit message.
>
> I personally use this a lot. It's better for scripting.
Yeah.
If this is generally annoying I guess I can rejig things to use --cc-cmd
instead, somehow, but it was very convenient because it meant the
machinery which split up the commits could also compute the Cc list at
the same time without having to record it separately, but I assumed it
was routinely done from the number of Cc: trailers already in the kernel
tree...
On Mon, Mar 06, 2023 at 05:04:55PM +0000, Nick Alcock wrote:
> On 3 Mar 2023, Lee Jones spake thusly:
...
> If this is generally annoying I guess I can rejig things to use --cc-cmd
> instead, somehow, but it was very convenient because it meant the
> machinery which split up the commits could also compute the Cc list at
> the same time without having to record it separately, but I assumed it
> was routinely done from the number of Cc: trailers already in the kernel
> tree...
For myself I have created a "smart" script [1], which I use on daily basis.
Feel free to take it, use it, give a feedback, etc.
[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
--
With Best Regards,
Andy Shevchenko