2023-03-03 12:59:34

by Muhammad Usama Anjum

[permalink] [raw]
Subject: [PATCH] qede: remove linux/version.h

make versioncheck reports the following:
./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.

So remove linux/version.h from both of these files.

Signed-off-by: Muhammad Usama Anjum <[email protected]>
---
drivers/net/ethernet/qlogic/qede/qede.h | 1 -
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
index f90dcfe9ee68..6ff1bd48d2aa 100644
--- a/drivers/net/ethernet/qlogic/qede/qede.h
+++ b/drivers/net/ethernet/qlogic/qede/qede.h
@@ -7,7 +7,6 @@
#ifndef _QEDE_H_
#define _QEDE_H_
#include <linux/compiler.h>
-#include <linux/version.h>
#include <linux/workqueue.h>
#include <linux/netdevice.h>
#include <linux/interrupt.h>
diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
index 8034d812d5a0..374a86b875a3 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
@@ -4,7 +4,6 @@
* Copyright (c) 2019-2020 Marvell International Ltd.
*/

-#include <linux/version.h>
#include <linux/types.h>
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
--
2.39.2



2023-03-03 15:36:43

by Alexander Lobakin

[permalink] [raw]
Subject: Re: [PATCH] qede: remove linux/version.h

From: Muhammad Usama Anjum <[email protected]>
Date: Fri, 3 Mar 2023 17:58:44 +0500

> make versioncheck reports the following:
> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
>
> So remove linux/version.h from both of these files.
>
> Signed-off-by: Muhammad Usama Anjum <[email protected]>
> ---
> drivers/net/ethernet/qlogic/qede/qede.h | 1 -
> drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
> index f90dcfe9ee68..6ff1bd48d2aa 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede.h
> +++ b/drivers/net/ethernet/qlogic/qede/qede.h
> @@ -7,7 +7,6 @@
> #ifndef _QEDE_H_
> #define _QEDE_H_
> #include <linux/compiler.h>

I think compiler.h is also unused, maybe this one too, while at it?

> -#include <linux/version.h>
> #include <linux/workqueue.h>
> #include <linux/netdevice.h>
> #include <linux/interrupt.h>
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> index 8034d812d5a0..374a86b875a3 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> @@ -4,7 +4,6 @@
> * Copyright (c) 2019-2020 Marvell International Ltd.
> */
>
> -#include <linux/version.h>
> #include <linux/types.h>
> #include <linux/netdevice.h>
> #include <linux/etherdevice.h>

Thanks,
Olek

2023-03-03 18:52:01

by Muhammad Usama Anjum

[permalink] [raw]
Subject: Re: [PATCH] qede: remove linux/version.h

On 3/3/23 8:35 PM, Alexander Lobakin wrote:
> From: Muhammad Usama Anjum <[email protected]>
> Date: Fri, 3 Mar 2023 17:58:44 +0500
>
>> make versioncheck reports the following:
>> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
>> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
>>
>> So remove linux/version.h from both of these files.
>>
>> Signed-off-by: Muhammad Usama Anjum <[email protected]>
>> ---
>> drivers/net/ethernet/qlogic/qede/qede.h | 1 -
>> drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
>> 2 files changed, 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
>> index f90dcfe9ee68..6ff1bd48d2aa 100644
>> --- a/drivers/net/ethernet/qlogic/qede/qede.h
>> +++ b/drivers/net/ethernet/qlogic/qede/qede.h
>> @@ -7,7 +7,6 @@
>> #ifndef _QEDE_H_
>> #define _QEDE_H_
>> #include <linux/compiler.h>
>
> I think compiler.h is also unused, maybe this one too, while at it?'
Just checked, it is also not being used. I'll send v2.

>
>> -#include <linux/version.h>
>> #include <linux/workqueue.h>
>> #include <linux/netdevice.h>
>> #include <linux/interrupt.h>
>> diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>> index 8034d812d5a0..374a86b875a3 100644
>> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>> +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
>> @@ -4,7 +4,6 @@
>> * Copyright (c) 2019-2020 Marvell International Ltd.
>> */
>>
>> -#include <linux/version.h>
>> #include <linux/types.h>
>> #include <linux/netdevice.h>
>> #include <linux/etherdevice.h>
>
> Thanks,
> Olek

--
BR,
Muhammad Usama Anjum