2023-03-05 20:26:38

by Danila Tikhonov

[permalink] [raw]
Subject: [PATCH 0/2] soc: qcom: llcc: Add support for SM7150

This series adds LLCC support for Qualcomm SM7150 SoC.

Danila Tikhonov (2):
dt-bindings: arm: msm: Add LLCC for SM7150
soc: qcom: llcc: Add configuration data for SM7150

.../devicetree/bindings/arm/msm/qcom,llcc.yaml | 1 +
drivers/soc/qcom/llcc-qcom.c | 17 +++++++++++++++++
2 files changed, 18 insertions(+)

--
2.39.2



2023-03-05 20:26:42

by Danila Tikhonov

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: arm: msm: Add LLCC for SM7150

Add LLCC compatible for SM7150 SoC.

Signed-off-by: Danila Tikhonov <[email protected]>
---
Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml
index 38efcad56dbd..0f838b899127 100644
--- a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml
+++ b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml
@@ -27,6 +27,7 @@ properties:
- qcom,sc8280xp-llcc
- qcom,sdm845-llcc
- qcom,sm6350-llcc
+ - qcom,sm7150-llcc
- qcom,sm8150-llcc
- qcom,sm8250-llcc
- qcom,sm8350-llcc
--
2.39.2


2023-03-05 20:27:04

by Danila Tikhonov

[permalink] [raw]
Subject: [PATCH 2/2] soc: qcom: llcc: Add configuration data for SM7150

Add LLCC configuration data for SM7150 SoC.

Signed-off-by: Danila Tikhonov <[email protected]>
---
drivers/soc/qcom/llcc-qcom.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 23ce2f78c4ed..0ed8cd4f66da 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -227,6 +227,14 @@ static const struct llcc_slice_config sm6350_data[] = {
{ LLCC_MODPE, 29, 64, 1, 1, 0xFFF, 0x0, 0, 0, 0, 0, 1, 0 },
};

+static const struct llcc_slice_config sm7150_data[] = {
+ { LLCC_CPUSS, 1, 512, 1, 0, 0xF, 0x0, 0, 0, 0, 1, 1 },
+ { LLCC_MDM, 8, 128, 2, 0, 0xF, 0x0, 0, 0, 0, 1, 0 },
+ { LLCC_GPUHTW, 11, 256, 1, 1, 0xF, 0x0, 0, 0, 0, 1, 0 },
+ { LLCC_GPU, 12, 256, 1, 1, 0xF, 0x0, 0, 0, 0, 1, 0 },
+ { LLCC_NPU, 23, 512, 1, 0, 0xF, 0x0, 0, 0, 0, 1, 0 },
+};
+
static const struct llcc_slice_config sm8150_data[] = {
{ LLCC_CPUSS, 1, 3072, 1, 1, 0xFFF, 0x0, 0, 0, 0, 1, 1 },
{ LLCC_VIDSC0, 2, 512, 2, 1, 0xFFF, 0x0, 0, 0, 0, 1, 0 },
@@ -464,6 +472,14 @@ static const struct qcom_llcc_config sm6350_cfg = {
.edac_reg_offset = &llcc_v1_edac_reg_offset,
};

+static const struct qcom_llcc_config sm7150_cfg = {
+ .sct_data = sm7150_data,
+ .size = ARRAY_SIZE(sm7150_data),
+ .need_llcc_cfg = true,
+ .reg_offset = llcc_v1_reg_offset,
+ .edac_reg_offset = &llcc_v1_edac_reg_offset,
+};
+
static const struct qcom_llcc_config sm8150_cfg = {
.sct_data = sm8150_data,
.size = ARRAY_SIZE(sm8150_data),
@@ -1022,6 +1038,7 @@ static const struct of_device_id qcom_llcc_of_match[] = {
{ .compatible = "qcom,sc8280xp-llcc", .data = &sc8280xp_cfg },
{ .compatible = "qcom,sdm845-llcc", .data = &sdm845_cfg },
{ .compatible = "qcom,sm6350-llcc", .data = &sm6350_cfg },
+ { .compatible = "qcom,sm7150-llcc", .data = &sm7150_cfg },
{ .compatible = "qcom,sm8150-llcc", .data = &sm8150_cfg },
{ .compatible = "qcom,sm8250-llcc", .data = &sm8250_cfg },
{ .compatible = "qcom,sm8350-llcc", .data = &sm8350_cfg },
--
2.39.2


2023-03-06 06:45:01

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: arm: msm: Add LLCC for SM7150

On 05/03/2023 21:26, Danila Tikhonov wrote:
> Add LLCC compatible for SM7150 SoC.
>
> Signed-off-by: Danila Tikhonov <[email protected]>
> ---


Acked-by: Krzysztof Kozlowski <[email protected]>
> - qcom,sm8350-llcc

Best regards,
Krzysztof


2023-03-06 10:42:02

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/2] soc: qcom: llcc: Add configuration data for SM7150



On 5.03.2023 21:26, Danila Tikhonov wrote:
> Add LLCC configuration data for SM7150 SoC.
>
> Signed-off-by: Danila Tikhonov <[email protected]>
> ---
I checked the msm-4.14 data, everything lgtm

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> drivers/soc/qcom/llcc-qcom.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> index 23ce2f78c4ed..0ed8cd4f66da 100644
> --- a/drivers/soc/qcom/llcc-qcom.c
> +++ b/drivers/soc/qcom/llcc-qcom.c
> @@ -227,6 +227,14 @@ static const struct llcc_slice_config sm6350_data[] = {
> { LLCC_MODPE, 29, 64, 1, 1, 0xFFF, 0x0, 0, 0, 0, 0, 1, 0 },
> };
>
> +static const struct llcc_slice_config sm7150_data[] = {
> + { LLCC_CPUSS, 1, 512, 1, 0, 0xF, 0x0, 0, 0, 0, 1, 1 },
> + { LLCC_MDM, 8, 128, 2, 0, 0xF, 0x0, 0, 0, 0, 1, 0 },
> + { LLCC_GPUHTW, 11, 256, 1, 1, 0xF, 0x0, 0, 0, 0, 1, 0 },
> + { LLCC_GPU, 12, 256, 1, 1, 0xF, 0x0, 0, 0, 0, 1, 0 },
> + { LLCC_NPU, 23, 512, 1, 0, 0xF, 0x0, 0, 0, 0, 1, 0 },
> +};
> +
> static const struct llcc_slice_config sm8150_data[] = {
> { LLCC_CPUSS, 1, 3072, 1, 1, 0xFFF, 0x0, 0, 0, 0, 1, 1 },
> { LLCC_VIDSC0, 2, 512, 2, 1, 0xFFF, 0x0, 0, 0, 0, 1, 0 },
> @@ -464,6 +472,14 @@ static const struct qcom_llcc_config sm6350_cfg = {
> .edac_reg_offset = &llcc_v1_edac_reg_offset,
> };
>
> +static const struct qcom_llcc_config sm7150_cfg = {
> + .sct_data = sm7150_data,
> + .size = ARRAY_SIZE(sm7150_data),
> + .need_llcc_cfg = true,
> + .reg_offset = llcc_v1_reg_offset,
> + .edac_reg_offset = &llcc_v1_edac_reg_offset,
> +};
> +
> static const struct qcom_llcc_config sm8150_cfg = {
> .sct_data = sm8150_data,
> .size = ARRAY_SIZE(sm8150_data),
> @@ -1022,6 +1038,7 @@ static const struct of_device_id qcom_llcc_of_match[] = {
> { .compatible = "qcom,sc8280xp-llcc", .data = &sc8280xp_cfg },
> { .compatible = "qcom,sdm845-llcc", .data = &sdm845_cfg },
> { .compatible = "qcom,sm6350-llcc", .data = &sm6350_cfg },
> + { .compatible = "qcom,sm7150-llcc", .data = &sm7150_cfg },
> { .compatible = "qcom,sm8150-llcc", .data = &sm8150_cfg },
> { .compatible = "qcom,sm8250-llcc", .data = &sm8250_cfg },
> { .compatible = "qcom,sm8350-llcc", .data = &sm8350_cfg },

2023-03-22 14:44:30

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH 0/2] soc: qcom: llcc: Add support for SM7150

On Sun, 5 Mar 2023 23:26:25 +0300, Danila Tikhonov wrote:
> This series adds LLCC support for Qualcomm SM7150 SoC.
>
> Danila Tikhonov (2):
> dt-bindings: arm: msm: Add LLCC for SM7150
> soc: qcom: llcc: Add configuration data for SM7150
>
> .../devicetree/bindings/arm/msm/qcom,llcc.yaml | 1 +
> drivers/soc/qcom/llcc-qcom.c | 17 +++++++++++++++++
> 2 files changed, 18 insertions(+)
>
> [...]

Applied, thanks!

[1/2] dt-bindings: arm: msm: Add LLCC for SM7150
commit: 1e0952e7b978eb4a182c4a9c003f9313d30d00df
[2/2] soc: qcom: llcc: Add configuration data for SM7150
commit: 92b9d86252c1d76faf06f155c2a73b0c673bf59d

Best regards,
--
Bjorn Andersson <[email protected]>