2023-03-08 05:50:01

by Yang Li

Subject: [PATCH -next] fbdev/clps711x-fb: Use devm_platform_get_and_ioremap_resource()

According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li <[email protected]>
---
drivers/video/fbdev/clps711x-fb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c
index 45c75ff01eca..c8bfc608bd9c 100644
--- a/drivers/video/fbdev/clps711x-fb.c
+++ b/drivers/video/fbdev/clps711x-fb.c
@@ -238,8 +238,7 @@ static int clps711x_fb_probe(struct platform_device *pdev)
info->fix.mmio_start = res->start;
info->fix.mmio_len = resource_size(res);

- res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
- info->screen_base = devm_ioremap_resource(dev, res);
+ info->screen_base = devm_platform_get_and_ioremap_resource(pdev, 1, &res);
if (IS_ERR(info->screen_base)) {
ret = PTR_ERR(info->screen_base);
goto out_fb_release;
--
2.20.1.7.g153144c

2023-03-11 11:57:54

by Helge Deller

Subject: Re: [PATCH -next] fbdev/clps711x-fb: Use devm_platform_get_and_ioremap_resource()

On 3/8/23 06:49, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <[email protected]>

applied.

Thanks!
Helge

> ---
> drivers/video/fbdev/clps711x-fb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c
> index 45c75ff01eca..c8bfc608bd9c 100644
> --- a/drivers/video/fbdev/clps711x-fb.c
> +++ b/drivers/video/fbdev/clps711x-fb.c
> @@ -238,8 +238,7 @@ static int clps711x_fb_probe(struct platform_device *pdev)
> info->fix.mmio_start = res->start;
> info->fix.mmio_len = resource_size(res);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> - info->screen_base = devm_ioremap_resource(dev, res);
> + info->screen_base = devm_platform_get_and_ioremap_resource(pdev, 1, &res);
> if (IS_ERR(info->screen_base)) {
> ret = PTR_ERR(info->screen_base);
> goto out_fb_release;