2023-03-08 12:27:39

by Nick Alcock

Subject: [PATCH] firmware: xilinx: nvmem: zynqmp: make modular

This driver has a MODULE_LICENSE but is not tristate so cannot be
built as a module, unlike all its peers: make it modular to match.

Signed-off-by: Nick Alcock <[email protected]>
Suggested-by: Michal Simek <[email protected]>
Cc: Luis Chamberlain <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Hitomi Hasegawa <[email protected]>
Cc: Srinivas Kandagatla <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: [email protected]
---
drivers/nvmem/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

How's this? (This supplants the previous patch, obviously.)

diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index 6dec38805041b..3b3832f4dfad1 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -368,7 +368,7 @@ config NVMEM_VF610_OCOTP
be called nvmem-vf610-ocotp.

config NVMEM_ZYNQMP
- bool "Xilinx ZYNQMP SoC nvmem firmware support"
+ tristate "Xilinx ZYNQMP SoC nvmem firmware support"
depends on ARCH_ZYNQMP
help
This is a driver to access hardware related data like
--
2.39.1.268.g9de2f9a303

2023-03-08 13:11:32

by Srinivas Kandagatla

Subject: Re: [PATCH] firmware: xilinx: nvmem: zynqmp: make modular

On 08/03/2023 12:27, Nick Alcock wrote:
> This driver has a MODULE_LICENSE but is not tristate so cannot be
> built as a module, unlike all its peers: make it modular to match.
>
> Signed-off-by: Nick Alcock <[email protected]>
> Suggested-by: Michal Simek <[email protected]>
> Cc: Luis Chamberlain <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: Hitomi Hasegawa <[email protected]>
> Cc: Srinivas Kandagatla <[email protected]>
> Cc: Michal Simek <[email protected]>
> Cc: [email protected]
> ---

Thanks for fixing this,

Applied thanks,

--srini
> drivers/nvmem/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> How's this? (This supplants the previous patch, obviously.)
>
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 6dec38805041b..3b3832f4dfad1 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -368,7 +368,7 @@ config NVMEM_VF610_OCOTP
> be called nvmem-vf610-ocotp.
>
> config NVMEM_ZYNQMP
> - bool "Xilinx ZYNQMP SoC nvmem firmware support"
> + tristate "Xilinx ZYNQMP SoC nvmem firmware support"
> depends on ARCH_ZYNQMP
> help
> This is a driver to access hardware related data like