2023-03-16 08:24:41

by Yu Zhe

Subject: [PATCH] usb: typec: tcpm: remove unnecessary (void*) conversions

Pointer variables of void * type do not require type cast.

Signed-off-by: Yu Zhe <[email protected]>
---
drivers/usb/typec/tcpm/fusb302.c | 2 +-
drivers/usb/typec/tcpm/tcpm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
index 1ffce00d94b4..4b7b8f6af3ca 100644
--- a/drivers/usb/typec/tcpm/fusb302.c
+++ b/drivers/usb/typec/tcpm/fusb302.c
@@ -190,7 +190,7 @@ static void fusb302_log(struct fusb302_chip *chip, const char *fmt, ...)

static int fusb302_debug_show(struct seq_file *s, void *v)
{
- struct fusb302_chip *chip = (struct fusb302_chip *)s->private;
+ struct fusb302_chip *chip = s->private;
int tail;

mutex_lock(&chip->logbuffer_lock);
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index a0d943d78580..e8bfe3f57ab4 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -737,7 +737,7 @@ static void tcpm_log_source_caps(struct tcpm_port *port)

static int tcpm_debug_show(struct seq_file *s, void *v)
{
- struct tcpm_port *port = (struct tcpm_port *)s->private;
+ struct tcpm_port *port = s->private;
int tail;

mutex_lock(&port->logbuffer_lock);
--
2.11.0

2023-03-17 11:29:28

by Heikki Krogerus

Subject: Re: [PATCH] usb: typec: tcpm: remove unnecessary (void*) conversions

On Thu, Mar 16, 2023 at 04:23:38PM +0800, Yu Zhe wrote:
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: Yu Zhe <[email protected]>

I would have prefered that both drivers are patched separately in
their own patch, but that's minor. If Guenter is OK with this then:

Acked-by: Heikki Krogerus <[email protected]>

> ---
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> drivers/usb/typec/tcpm/tcpm.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 1ffce00d94b4..4b7b8f6af3ca 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -190,7 +190,7 @@ static void fusb302_log(struct fusb302_chip *chip, const char *fmt, ...)
>
> static int fusb302_debug_show(struct seq_file *s, void *v)
> {
> - struct fusb302_chip *chip = (struct fusb302_chip *)s->private;
> + struct fusb302_chip *chip = s->private;
> int tail;
>
> mutex_lock(&chip->logbuffer_lock);
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index a0d943d78580..e8bfe3f57ab4 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -737,7 +737,7 @@ static void tcpm_log_source_caps(struct tcpm_port *port)
>
> static int tcpm_debug_show(struct seq_file *s, void *v)
> {
> - struct tcpm_port *port = (struct tcpm_port *)s->private;
> + struct tcpm_port *port = s->private;
> int tail;
>
> mutex_lock(&port->logbuffer_lock);
> --
> 2.11.0

--
heikki

2023-03-17 12:18:33

by Guenter Roeck

Subject: Re: [PATCH] usb: typec: tcpm: remove unnecessary (void*) conversions

On 3/17/23 04:29, Heikki Krogerus wrote:
> On Thu, Mar 16, 2023 at 04:23:38PM +0800, Yu Zhe wrote:
>> Pointer variables of void * type do not require type cast.
>>
>> Signed-off-by: Yu Zhe <[email protected]>
>
> I would have prefered that both drivers are patched separately in
> their own patch, but that's minor. If Guenter is OK with this then:
>
> Acked-by: Heikki Krogerus <[email protected]>
>

I seem to have missed the original patch. Anyway, lgtm

Reviewed-by: Guenter Roeck <[email protected]>

And, yes, those should really have been separate patches, one per driver.

Guenter

>> ---
>> drivers/usb/typec/tcpm/fusb302.c | 2 +-
>> drivers/usb/typec/tcpm/tcpm.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
>> index 1ffce00d94b4..4b7b8f6af3ca 100644
>> --- a/drivers/usb/typec/tcpm/fusb302.c
>> +++ b/drivers/usb/typec/tcpm/fusb302.c
>> @@ -190,7 +190,7 @@ static void fusb302_log(struct fusb302_chip *chip, const char *fmt, ...)
>>
>> static int fusb302_debug_show(struct seq_file *s, void *v)
>> {
>> - struct fusb302_chip *chip = (struct fusb302_chip *)s->private;
>> + struct fusb302_chip *chip = s->private;
>> int tail;
>>
>> mutex_lock(&chip->logbuffer_lock);
>> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
>> index a0d943d78580..e8bfe3f57ab4 100644
>> --- a/drivers/usb/typec/tcpm/tcpm.c
>> +++ b/drivers/usb/typec/tcpm/tcpm.c
>> @@ -737,7 +737,7 @@ static void tcpm_log_source_caps(struct tcpm_port *port)
>>
>> static int tcpm_debug_show(struct seq_file *s, void *v)
>> {
>> - struct tcpm_port *port = (struct tcpm_port *)s->private;
>> + struct tcpm_port *port = s->private;
>> int tail;
>>
>> mutex_lock(&port->logbuffer_lock);
>> --
>> 2.11.0
>