2023-03-16 08:53:56

by Yu Zhe

Subject: [PATCH] tpm: remove unnecessary (void*) conversions

Pointer variables of void * type do not require type cast.

Signed-off-by: Yu Zhe <[email protected]>
---
drivers/char/tpm/eventlog/common.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/char/tpm/eventlog/common.c b/drivers/char/tpm/eventlog/common.c
index 8512ec76d526..639c3f395a5a 100644
--- a/drivers/char/tpm/eventlog/common.c
+++ b/drivers/char/tpm/eventlog/common.c
@@ -36,7 +36,7 @@ static int tpm_bios_measurements_open(struct inode *inode,
inode_unlock(inode);
return -ENODEV;
}
- chip_seqops = (struct tpm_chip_seqops *)inode->i_private;
+ chip_seqops = inode->i_private;
seqops = chip_seqops->seqops;
chip = chip_seqops->chip;
get_device(&chip->dev);
@@ -55,8 +55,8 @@ static int tpm_bios_measurements_open(struct inode *inode,
static int tpm_bios_measurements_release(struct inode *inode,
struct file *file)
{
- struct seq_file *seq = (struct seq_file *)file->private_data;
- struct tpm_chip *chip = (struct tpm_chip *)seq->private;
+ struct seq_file *seq = file->private_data;
+ struct tpm_chip *chip = seq->private;

put_device(&chip->dev);

--
2.11.0

2023-03-19 13:45:45

by Jarkko Sakkinen

Subject: Re: [PATCH] tpm: remove unnecessary (void*) conversions

On Thu, Mar 16, 2023 at 04:50:37PM +0800, Yu Zhe wrote:
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: Yu Zhe <[email protected]>
> ---
> drivers/char/tpm/eventlog/common.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/tpm/eventlog/common.c b/drivers/char/tpm/eventlog/common.c
> index 8512ec76d526..639c3f395a5a 100644
> --- a/drivers/char/tpm/eventlog/common.c
> +++ b/drivers/char/tpm/eventlog/common.c
> @@ -36,7 +36,7 @@ static int tpm_bios_measurements_open(struct inode *inode,
> inode_unlock(inode);
> return -ENODEV;
> }
> - chip_seqops = (struct tpm_chip_seqops *)inode->i_private;
> + chip_seqops = inode->i_private;
> seqops = chip_seqops->seqops;
> chip = chip_seqops->chip;
> get_device(&chip->dev);
> @@ -55,8 +55,8 @@ static int tpm_bios_measurements_open(struct inode *inode,
> static int tpm_bios_measurements_release(struct inode *inode,
> struct file *file)
> {
> - struct seq_file *seq = (struct seq_file *)file->private_data;
> - struct tpm_chip *chip = (struct tpm_chip *)seq->private;
> + struct seq_file *seq = file->private_data;
> + struct tpm_chip *chip = seq->private;
>
> put_device(&chip->dev);
>
> --
> 2.11.0
>

Acked-by: Jarkko Sakkinen <[email protected]>

BR, Jarkko