2023-03-14 00:47:01

by Luck, Tony

Subject: [PATCH] ACPI: APEI: EINJ: Add CXL error types

ACPI 6.5 added six new error types for CXL. See chapter 18
table 18.30.

Add strings for the new types so that Linux will list them in the
/sys/kernel/debug/apei/einj/available_error_types file.

It seems no other changes are needed. Linux already accepts
the CXL codes (on a BIOS that advertises them).

Signed-off-by: Tony Luck <[email protected]>
---
drivers/acpi/apei/einj.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
index b4373e575660..39bee5a067cc 100644
--- a/drivers/acpi/apei/einj.c
+++ b/drivers/acpi/apei/einj.c
@@ -584,6 +584,12 @@ static const char * const einj_error_type_string[] = {
"0x00000200\tPlatform Correctable\n",
"0x00000400\tPlatform Uncorrectable non-fatal\n",
"0x00000800\tPlatform Uncorrectable fatal\n",
+ "0x00001000\tCXL.cache Protocol Correctable\n",
+ "0x00002000\tCXL.cache Protocol Uncorrectable non-fatal\n",
+ "0x00004000\tCXL.cache Protocol Uncorrectable fatal\n",
+ "0x00008000\tCXL.mem Protocol Correctable\n",
+ "0x00010000\tCXL.mem Protocol Uncorrectable non-fatal\n",
+ "0x00020000\tCXL.mem Protocol Uncorrectable fatal\n",
};

static int available_error_type_show(struct seq_file *m, void *v)
--
2.39.2

2023-03-16 20:24:12

by Davidlohr Bueso

Subject: Re: [PATCH] ACPI: APEI: EINJ: Add CXL error types

On Mon, 13 Mar 2023, Tony Luck wrote:

>ACPI 6.5 added six new error types for CXL. See chapter 18
>table 18.30.
>
>Add strings for the new types so that Linux will list them in the
>/sys/kernel/debug/apei/einj/available_error_types file.
>
>It seems no other changes are needed. Linux already accepts
>the CXL codes (on a BIOS that advertises them).
>
>Signed-off-by: Tony Luck <[email protected]>

Reviewed-by: Davidlohr Bueso <[email protected]>

>---
> drivers/acpi/apei/einj.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
>index b4373e575660..39bee5a067cc 100644
>--- a/drivers/acpi/apei/einj.c
>+++ b/drivers/acpi/apei/einj.c
>@@ -584,6 +584,12 @@ static const char * const einj_error_type_string[] = {
> "0x00000200\tPlatform Correctable\n",
> "0x00000400\tPlatform Uncorrectable non-fatal\n",
> "0x00000800\tPlatform Uncorrectable fatal\n",
>+ "0x00001000\tCXL.cache Protocol Correctable\n",
>+ "0x00002000\tCXL.cache Protocol Uncorrectable non-fatal\n",
>+ "0x00004000\tCXL.cache Protocol Uncorrectable fatal\n",
>+ "0x00008000\tCXL.mem Protocol Correctable\n",
>+ "0x00010000\tCXL.mem Protocol Uncorrectable non-fatal\n",
>+ "0x00020000\tCXL.mem Protocol Uncorrectable fatal\n",
> };
>
> static int available_error_type_show(struct seq_file *m, void *v)
>--
>2.39.2
>

2023-03-16 20:26:25

by Dave Jiang

Subject: Re: [PATCH] ACPI: APEI: EINJ: Add CXL error types

On 3/13/23 5:46 PM, Tony Luck wrote:
> ACPI 6.5 added six new error types for CXL. See chapter 18
> table 18.30.
>
> Add strings for the new types so that Linux will list them in the
> /sys/kernel/debug/apei/einj/available_error_types file.
>
> It seems no other changes are needed. Linux already accepts
> the CXL codes (on a BIOS that advertises them).
>
> Signed-off-by: Tony Luck <[email protected]>

Reviewed-by: Dave Jiang <[email protected]>

> ---
> drivers/acpi/apei/einj.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
> index b4373e575660..39bee5a067cc 100644
> --- a/drivers/acpi/apei/einj.c
> +++ b/drivers/acpi/apei/einj.c
> @@ -584,6 +584,12 @@ static const char * const einj_error_type_string[] = {
> "0x00000200\tPlatform Correctable\n",
> "0x00000400\tPlatform Uncorrectable non-fatal\n",
> "0x00000800\tPlatform Uncorrectable fatal\n",
> + "0x00001000\tCXL.cache Protocol Correctable\n",
> + "0x00002000\tCXL.cache Protocol Uncorrectable non-fatal\n",
> + "0x00004000\tCXL.cache Protocol Uncorrectable fatal\n",
> + "0x00008000\tCXL.mem Protocol Correctable\n",
> + "0x00010000\tCXL.mem Protocol Uncorrectable non-fatal\n",
> + "0x00020000\tCXL.mem Protocol Uncorrectable fatal\n",
> };
>
> static int available_error_type_show(struct seq_file *m, void *v)

2023-03-20 17:44:21

by Rafael J. Wysocki

Subject: Re: [PATCH] ACPI: APEI: EINJ: Add CXL error types

On Tue, Mar 14, 2023 at 1:47 AM Tony Luck <[email protected]> wrote:
>
> ACPI 6.5 added six new error types for CXL. See chapter 18
> table 18.30.
>
> Add strings for the new types so that Linux will list them in the
> /sys/kernel/debug/apei/einj/available_error_types file.
>
> It seems no other changes are needed. Linux already accepts
> the CXL codes (on a BIOS that advertises them).
>
> Signed-off-by: Tony Luck <[email protected]>
> ---
> drivers/acpi/apei/einj.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
> index b4373e575660..39bee5a067cc 100644
> --- a/drivers/acpi/apei/einj.c
> +++ b/drivers/acpi/apei/einj.c
> @@ -584,6 +584,12 @@ static const char * const einj_error_type_string[] = {
> "0x00000200\tPlatform Correctable\n",
> "0x00000400\tPlatform Uncorrectable non-fatal\n",
> "0x00000800\tPlatform Uncorrectable fatal\n",
> + "0x00001000\tCXL.cache Protocol Correctable\n",
> + "0x00002000\tCXL.cache Protocol Uncorrectable non-fatal\n",
> + "0x00004000\tCXL.cache Protocol Uncorrectable fatal\n",
> + "0x00008000\tCXL.mem Protocol Correctable\n",
> + "0x00010000\tCXL.mem Protocol Uncorrectable non-fatal\n",
> + "0x00020000\tCXL.mem Protocol Uncorrectable fatal\n",
> };
>
> static int available_error_type_show(struct seq_file *m, void *v)
> --

Applied as 6.4 material, thanks!