2023-03-16 20:55:25

by Rouven Czerwinski

[permalink] [raw]
Subject: [PATCH] ARM: npcm: remove select of non-existant ERRATA

config ARCH_NPCM7XX selects ARM_ERRATA_794072, however this config
option does not exist since the workaround for the errata requires
secure mode access which needs to be run by the bootloader or firmware
since linux can't determine whether it is running in secure mode.

Signed-off-by: Rouven Czerwinski <[email protected]>
---
arch/arm/mach-npcm/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-npcm/Kconfig b/arch/arm/mach-npcm/Kconfig
index 63b42a19d1b8..d933e8abb50f 100644
--- a/arch/arm/mach-npcm/Kconfig
+++ b/arch/arm/mach-npcm/Kconfig
@@ -30,7 +30,6 @@ config ARCH_NPCM7XX
select ARM_ERRATA_764369 if SMP
select ARM_ERRATA_720789
select ARM_ERRATA_754322
- select ARM_ERRATA_794072
select PL310_ERRATA_588369
select PL310_ERRATA_727915
select MFD_SYSCON
--
2.39.2



2023-03-22 08:03:53

by Paul Menzel

[permalink] [raw]
Subject: Re: [PATCH] ARM: npcm: remove select of non-existant ERRATA

Dear Rouven,


Thank you for your patch.

Am 16.03.23 um 21:47 schrieb Rouven Czerwinski:

There is a small typo in the commit message summary/title:
non-exist*e*nt. Maybe also mention the errata number:

ARM: npcm: Remove select of non-existent ARM_ERRATA_794072

> config ARCH_NPCM7XX selects ARM_ERRATA_794072, however this config
> option does not exist since the workaround for the errata requires
> secure mode access which needs to be run by the bootloader or firmware
> since linux can't determine whether it is running in secure mode.

Please add a Fixes: tag.

> Signed-off-by: Rouven Czerwinski <[email protected]>
> ---
> arch/arm/mach-npcm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-npcm/Kconfig b/arch/arm/mach-npcm/Kconfig
> index 63b42a19d1b8..d933e8abb50f 100644
> --- a/arch/arm/mach-npcm/Kconfig
> +++ b/arch/arm/mach-npcm/Kconfig
> @@ -30,7 +30,6 @@ config ARCH_NPCM7XX
> select ARM_ERRATA_764369 if SMP
> select ARM_ERRATA_720789
> select ARM_ERRATA_754322
> - select ARM_ERRATA_794072
> select PL310_ERRATA_588369
> select PL310_ERRATA_727915
> select MFD_SYSCON

Reviewed-by: Paul Menzel <[email protected]>


Kind regards,

Paul