2023-03-19 04:28:11

by Lizhe

[permalink] [raw]
Subject: [PATCH v1] scsi: scsi_debug: Remove redundant driver match function

If there is no driver match function, the driver core assumes that each
candidate pair (driver, device) matches, see driver_match_device()

Drop the pseudo_lld bus's match function that always returned 1 and so
implements the same behaviour as when there is no match function.

Signed-off-by: Lizhe <[email protected]>
---
drivers/scsi/scsi_debug.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 8553277effb3..fa6f150b7364 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -7950,15 +7950,8 @@ static void sdebug_driver_remove(struct device *dev)
scsi_host_put(sdbg_host->shost);
}

-static int pseudo_lld_bus_match(struct device *dev,
- struct device_driver *dev_driver)
-{
- return 1;
-}
-
static struct bus_type pseudo_lld_bus = {
.name = "pseudo",
- .match = pseudo_lld_bus_match,
.probe = sdebug_driver_probe,
.remove = sdebug_driver_remove,
.drv_groups = sdebug_drv_groups,
--
2.34.1



2023-03-21 17:52:33

by John Garry

[permalink] [raw]
Subject: Re: [PATCH v1] scsi: scsi_debug: Remove redundant driver match function

On 19/03/2023 04:27, Lizhe wrote:
> If there is no driver match function, the driver core assumes that each
> candidate pair (driver, device) matches, see driver_match_device()
>
> Drop the pseudo_lld bus's match function that always returned 1 and so

I'd have "Drop the pseudo_lld_bus match function .."

> implements the same behaviour as when there is no match function.
>
> Signed-off-by: Lizhe<[email protected]>
> ---

Reviewed-by: John Garry <[email protected]>

2023-03-24 21:46:25

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH v1] scsi: scsi_debug: Remove redundant driver match function


Lizhe,

> If there is no driver match function, the driver core assumes that each
> candidate pair (driver, device) matches, see driver_match_device()
>
> Drop the pseudo_lld bus's match function that always returned 1 and so
> implements the same behaviour as when there is no match function.

Applied to 6.4/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering