2023-03-19 16:48:59

by Tom Rix

Subject: [PATCH] mmc: sdricoh_cs: remove unused sdricoh_readw function

clang with W=1 reports
drivers/mmc/host/sdricoh_cs.c:104:28: error: unused function
'sdricoh_readw' [-Werror,-Wunused-function]
static inline unsigned int sdricoh_readw(struct sdricoh_host *host,
^
This function is not used, so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/mmc/host/sdricoh_cs.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdricoh_cs.c
index 76a8cd3a186f..57b8c1a96756 100644
--- a/drivers/mmc/host/sdricoh_cs.c
+++ b/drivers/mmc/host/sdricoh_cs.c
@@ -101,14 +101,6 @@ static inline void sdricoh_writel(struct sdricoh_host *host, unsigned int reg,

}

-static inline unsigned int sdricoh_readw(struct sdricoh_host *host,
- unsigned int reg)
-{
- unsigned int value = readw(host->iobase + reg);
- dev_vdbg(host->dev, "rb %x 0x%x\n", reg, value);
- return value;
-}
-
static inline void sdricoh_writew(struct sdricoh_host *host, unsigned int reg,
unsigned short value)
{
--
2.27.0

2023-03-23 12:18:05

by Ulf Hansson

Subject: Re: [PATCH] mmc: sdricoh_cs: remove unused sdricoh_readw function

On Sun, 19 Mar 2023 at 17:47, Tom Rix <[email protected]> wrote:
>
> clang with W=1 reports
> drivers/mmc/host/sdricoh_cs.c:104:28: error: unused function
> 'sdricoh_readw' [-Werror,-Wunused-function]
> static inline unsigned int sdricoh_readw(struct sdricoh_host *host,
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/sdricoh_cs.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdricoh_cs.c
> index 76a8cd3a186f..57b8c1a96756 100644
> --- a/drivers/mmc/host/sdricoh_cs.c
> +++ b/drivers/mmc/host/sdricoh_cs.c
> @@ -101,14 +101,6 @@ static inline void sdricoh_writel(struct sdricoh_host *host, unsigned int reg,
>
> }
>
> -static inline unsigned int sdricoh_readw(struct sdricoh_host *host,
> - unsigned int reg)
> -{
> - unsigned int value = readw(host->iobase + reg);
> - dev_vdbg(host->dev, "rb %x 0x%x\n", reg, value);
> - return value;
> -}
> -
> static inline void sdricoh_writew(struct sdricoh_host *host, unsigned int reg,
> unsigned short value)
> {
> --
> 2.27.0
>