Hi all,
After merging the leds-lj tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/leds/rgb/leds-mt6370-rgb.c: In function 'mt6370_check_vendor_info':
drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
889 | vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
| ^~~~~~~~~
Caused by commit
55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
I have used the leds-lj tree from next-20230317 for today.
--
Cheers,
Stephen Rothwell
On Mon, Mar 20, 2023 at 11:48:16AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/leds/rgb/leds-mt6370-rgb.c: In function 'mt6370_check_vendor_info':
> drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
> 889 | vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
> | ^~~~~~~~~
>
> Caused by commit
>
> 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
>
> I have used the leds-lj tree from next-20230317 for today.
>
Already sent the patch.
https://lore.kernel.org/lkml/[email protected]/
Wait for reviewing.
> --
> Cheers,
> Stephen Rothwell
Hi all,
On Mon, 20 Mar 2023 11:48:16 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/leds/rgb/leds-mt6370-rgb.c: In function 'mt6370_check_vendor_info':
> drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
> 889 | vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
> | ^~~~~~~~~
>
> Caused by commit
>
> 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
>
> I have used the leds-lj tree from next-20230317 for today.
I am still getting this build failure.
--
Cheers,
Stephen Rothwell
On Wed, 22 Mar 2023, Stephen Rothwell wrote:
> Hi all,
>
> On Mon, 20 Mar 2023 11:48:16 +1100 Stephen Rothwell <[email protected]> wrote:
> >
> > After merging the leds-lj tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/leds/rgb/leds-mt6370-rgb.c: In function 'mt6370_check_vendor_info':
> > drivers/leds/rgb/leds-mt6370-rgb.c:889:15: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
> > 889 | vid = FIELD_GET(MT6370_VENDOR_ID_MASK, devinfo);
> > | ^~~~~~~~~
> >
> > Caused by commit
> >
> > 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support")
> >
> > I have used the leds-lj tree from next-20230317 for today.
>
> I am still getting this build failure.
Fix applied and pushed. Thanks for the reminder.
--
Lee Jones [李琼斯]
On 8/9/23 05:17, Stephen Rothwell wrote:
> Hi all,
>
> After merging the leds-lj tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> FATAL: modpost: drivers/leds/leds-pca995x: sizeof(struct i2c_device_id)=32 is not a modulo of the size of section __mod_i2c__<identifier>_device_table=600.
> Fix definition of struct i2c_device_id in mod_devicetable.h
>
> Presumably caused by commit
>
> ee4e80b2962e ("leds: pca995x: Add support for PCA995X chips")
>
> I have reverted that commit for today.
Ah doh, the fix is trivial, proper patch is coming in a bit.
diff --git a/drivers/leds/leds-pca995x.c b/drivers/leds/leds-pca995x.c
index 3ac99a433fcd2..78215dff14997 100644
--- a/drivers/leds/leds-pca995x.c
+++ b/drivers/leds/leds-pca995x.c
@@ -187,7 +187,7 @@ static const struct of_device_id pca995x_of_match[] = {
{ .compatible = "nxp,pca9955b", .data = (void *)PCA995X_TYPE_B },
{},
};
-MODULE_DEVICE_TABLE(i2c, pca995x_of_match);
+MODULE_DEVICE_TABLE(of, pca995x_of_match);
static struct i2c_driver pca995x_driver = {
.driver = {