2023-03-22 08:24:47

by Mike Rapoport

Subject: [PATCH] mips: drop ranges for definition of ARCH_FORCE_MAX_ORDER

From: "Mike Rapoport (IBM)" <[email protected]>

MIPS defines insane ranges for ARCH_FORCE_MAX_ORDER allowing MAX_ORDER
up to 63, which implies maximal contiguous allocation size of 2^63
pages.

Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a
simple integer with sensible defaults.

Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER
will be able to do so but they won't be mislead by the bogus ranges.

Signed-off-by: Mike Rapoport (IBM) <[email protected]>
---
arch/mips/Kconfig | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 3e8b765b8c7b..a0f6e9d0a561 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2137,13 +2137,9 @@ endchoice

config ARCH_FORCE_MAX_ORDER
int "Maximum zone order"
- range 13 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB
default "13" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB
- range 12 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB
default "12" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB
- range 11 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
default "11" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
- range 0 63
default "10"
help
The kernel memory allocator divides physically contiguous memory
--
2.35.1

2023-03-22 08:35:38

by Mike Rapoport

Subject: Re: [PATCH] mips: drop ranges for definition of ARCH_FORCE_MAX_ORDER

Forgot to mention that the patch is on top of akpm/mm-unstable

On Wed, Mar 22, 2023 at 10:15:20AM +0200, Mike Rapoport wrote:
> From: "Mike Rapoport (IBM)" <[email protected]>
>
> MIPS defines insane ranges for ARCH_FORCE_MAX_ORDER allowing MAX_ORDER
> up to 63, which implies maximal contiguous allocation size of 2^63
> pages.
>
> Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a
> simple integer with sensible defaults.
>
> Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER
> will be able to do so but they won't be mislead by the bogus ranges.
>
> Signed-off-by: Mike Rapoport (IBM) <[email protected]>
> ---
> arch/mips/Kconfig | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 3e8b765b8c7b..a0f6e9d0a561 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2137,13 +2137,9 @@ endchoice
>
> config ARCH_FORCE_MAX_ORDER
> int "Maximum zone order"
> - range 13 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB
> default "13" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB
> - range 12 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB
> default "12" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB
> - range 11 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
> default "11" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
> - range 0 63
> default "10"
> help
> The kernel memory allocator divides physically contiguous memory
> --
> 2.35.1
>

--
Sincerely yours,
Mike.

2023-03-22 09:07:05

by Thomas Bogendoerfer

Subject: Re: [PATCH] mips: drop ranges for definition of ARCH_FORCE_MAX_ORDER

On Wed, Mar 22, 2023 at 10:15:20AM +0200, Mike Rapoport wrote:
> From: "Mike Rapoport (IBM)" <[email protected]>
>
> MIPS defines insane ranges for ARCH_FORCE_MAX_ORDER allowing MAX_ORDER
> up to 63, which implies maximal contiguous allocation size of 2^63
> pages.
>
> Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a
> simple integer with sensible defaults.
>
> Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER
> will be able to do so but they won't be mislead by the bogus ranges.
>
> Signed-off-by: Mike Rapoport (IBM) <[email protected]>
> ---
> arch/mips/Kconfig | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 3e8b765b8c7b..a0f6e9d0a561 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2137,13 +2137,9 @@ endchoice
>
> config ARCH_FORCE_MAX_ORDER
> int "Maximum zone order"
> - range 13 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB
> default "13" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB
> - range 12 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB
> default "12" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB
> - range 11 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
> default "11" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
> - range 0 63
> default "10"
> help
> The kernel memory allocator divides physically contiguous memory
> --
> 2.35.1

Thank you for cleaning this up.

Acked-by: Thomas Bogendoerfer <[email protected]>

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]

2023-03-22 10:09:25

by Kirill A. Shutemov

Subject: Re: [PATCH] mips: drop ranges for definition of ARCH_FORCE_MAX_ORDER

On Wed, Mar 22, 2023 at 10:15:20AM +0200, Mike Rapoport wrote:
> From: "Mike Rapoport (IBM)" <[email protected]>
>
> MIPS defines insane ranges for ARCH_FORCE_MAX_ORDER allowing MAX_ORDER
> up to 63, which implies maximal contiguous allocation size of 2^63
> pages.
>
> Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a
> simple integer with sensible defaults.
>
> Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER
> will be able to do so but they won't be mislead by the bogus ranges.
>
> Signed-off-by: Mike Rapoport (IBM) <[email protected]>

Acked-by: Kirill A. Shutemov <[email protected]>

--
Kiryl Shutsemau / Kirill A. Shutemov

2023-03-22 17:19:37

by David Hildenbrand

Subject: Re: [PATCH] mips: drop ranges for definition of ARCH_FORCE_MAX_ORDER

On 22.03.23 09:15, Mike Rapoport wrote:
> From: "Mike Rapoport (IBM)" <[email protected]>
>
> MIPS defines insane ranges for ARCH_FORCE_MAX_ORDER allowing MAX_ORDER
> up to 63, which implies maximal contiguous allocation size of 2^63
> pages.
>
> Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a
> simple integer with sensible defaults.
>
> Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER
> will be able to do so but they won't be mislead by the bogus ranges.
>
> Signed-off-by: Mike Rapoport (IBM) <[email protected]>
> ---
> arch/mips/Kconfig | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 3e8b765b8c7b..a0f6e9d0a561 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2137,13 +2137,9 @@ endchoice
>
> config ARCH_FORCE_MAX_ORDER
> int "Maximum zone order"
> - range 13 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB
> default "13" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB
> - range 12 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB
> default "12" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB
> - range 11 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
> default "11" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB
> - range 0 63
> default "10"
> help
> The kernel memory allocator divides physically contiguous memory

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb