2023-03-27 07:38:08

by Cai Huoqing

Subject: [PATCH] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()

Use pci_p2pdma_map_segment() instead of pci_p2pmem_dma(),
because pci_p2pmem_dma() is already removed.

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/pci/p2pdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
index 9e8205572830..4f1798ecf38f 100644
--- a/drivers/pci/p2pdma.c
+++ b/drivers/pci/p2pdma.c
@@ -747,7 +747,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
/**
* pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
* the specified list of clients and shortest distance (as determined
- * by pci_p2pmem_dma())
+ * by pci_p2pdma_map_segment())
* @clients: array of devices to check (NULL-terminated)
* @num_clients: number of client devices in the list
*
--
2.34.1

2023-03-27 15:49:46

by Logan Gunthorpe

Subject: Re: [PATCH] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()

On 2023-03-27 01:36, Cai Huoqing wrote:
> Use pci_p2pdma_map_segment() instead of pci_p2pmem_dma(),
> because pci_p2pmem_dma() is already removed.
>
> Signed-off-by: Cai Huoqing <[email protected]>

Thanks for noticing this!

> ---
> drivers/pci/p2pdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index 9e8205572830..4f1798ecf38f 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -747,7 +747,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
> /**
> * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
> * the specified list of clients and shortest distance (as determined
> - * by pci_p2pmem_dma())
> + * by pci_p2pdma_map_segment())

Maybe we should just remove the reference to pci_p2pdma_map_segment()
completely. I don't see how that function helps the reader any more and
is really different section of the API anyway.

Logan