Remove pci_p2pmem_dma() reference,
because pci_p2pmem_dma() method is already removed.
Signed-off-by: Cai Huoqing <[email protected]>
---
v1->v2:
1.remove pci_p2pmem_dma() reference directly instead of
using pci_p2pdma_map_segment().
v1 link:
https://lore.kernel.org/lkml/[email protected]/
drivers/pci/p2pdma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
index 9e8205572830..6cd98ffca198 100644
--- a/drivers/pci/p2pdma.c
+++ b/drivers/pci/p2pdma.c
@@ -746,8 +746,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
/**
* pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
- * the specified list of clients and shortest distance (as determined
- * by pci_p2pmem_dma())
+ * the specified list of clients and shortest distance
* @clients: array of devices to check (NULL-terminated)
* @num_clients: number of client devices in the list
*
--
2.34.1
On 2023-03-28 05:06, Cai Huoqing wrote:
> Remove pci_p2pmem_dma() reference,
> because pci_p2pmem_dma() method is already removed.
>
> Signed-off-by: Cai Huoqing <[email protected]>
Looks good to me, thanks.
Reviewed-by: Logan Gunthorpe <[email protected]>
> ---
> v1->v2:
> 1.remove pci_p2pmem_dma() reference directly instead of
> using pci_p2pdma_map_segment().
>
> v1 link:
> https://lore.kernel.org/lkml/[email protected]/
>
> drivers/pci/p2pdma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index 9e8205572830..6cd98ffca198 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -746,8 +746,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
>
> /**
> * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
> - * the specified list of clients and shortest distance (as determined
> - * by pci_p2pmem_dma())
> + * the specified list of clients and shortest distance
> * @clients: array of devices to check (NULL-terminated)
> * @num_clients: number of client devices in the list
> *
On Tue, Mar 28, 2023 at 07:06:10PM +0800, Cai Huoqing wrote:
> Remove pci_p2pmem_dma() reference,
> because pci_p2pmem_dma() method is already removed.
AFAICT, pci_p2pmem_dma() *never* existed. I suppose it was a typo,
and pci_p2pdma_distance_many() was intended?
I'm happy to either merge this patch (with an updated commit log) to
remove the comment text or merge a patch correct the comment text.
I just don't want to merge this with a commit log that says we removed
the pci_p2pmem_dma() method when it never actually existed.
> Signed-off-by: Cai Huoqing <[email protected]>
> ---
> v1->v2:
> 1.remove pci_p2pmem_dma() reference directly instead of
> using pci_p2pdma_map_segment().
>
> v1 link:
> https://lore.kernel.org/lkml/[email protected]/
>
> drivers/pci/p2pdma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index 9e8205572830..6cd98ffca198 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -746,8 +746,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
>
> /**
> * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
> - * the specified list of clients and shortest distance (as determined
> - * by pci_p2pmem_dma())
> + * the specified list of clients and shortest distance
> * @clients: array of devices to check (NULL-terminated)
> * @num_clients: number of client devices in the list
> *
> --
> 2.34.1
>
On 2023-03-28 11:34, Bjorn Helgaas wrote:
> On Tue, Mar 28, 2023 at 07:06:10PM +0800, Cai Huoqing wrote:
>> Remove pci_p2pmem_dma() reference,
>> because pci_p2pmem_dma() method is already removed.
>
> AFAICT, pci_p2pmem_dma() *never* existed. I suppose it was a typo,
> and pci_p2pdma_distance_many() was intended?
>
> I'm happy to either merge this patch (with an updated commit log) to
> remove the comment text or merge a patch correct the comment text.
>
> I just don't want to merge this with a commit log that says we removed
> the pci_p2pmem_dma() method when it never actually existed.
Ah, yes that's fair. I thought pci_p2pmem_dma() was an odd function
name. Good to confirm it never existed.
Thanks,
Logan