2023-03-29 18:07:28

by Caio Novais

Subject: [PATCH v2 0/2] drm/amd/display: Remove a unused variable and mark a function as static

This patchset removes one unused variable and mark a function as static.

Caio Novais (2):
drm/amd/display: Remove unused variable 'scl_enable'
drm/amd/display: Mark function
'optc3_wait_drr_doublebuffer_pending_clear' as static

drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 2 +-
.../gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)

--
2.40.0

2023-03-29 18:08:55

by Caio Novais

Subject: [PATCH v2 2/2] drm/amd/display: Mark function 'optc3_wait_drr_doublebuffer_pending_clear' as static

Compiling AMD GPU drivers displays a warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:294:6: warning: no previous prototype for ‘optc3_wait_drr_doublebuffer_pending_clear’ [-Wmissing-prototypes]

Get rid of it by marking the function as static

Signed-off-by: Caio Novais <[email protected]>
---
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
index 08b92715e2e6..c95f000b63b2 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
@@ -291,7 +291,7 @@ static void optc3_set_timing_double_buffer(struct timing_generator *optc, bool e
OTG_DRR_TIMING_DBUF_UPDATE_MODE, mode);
}

-void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)
+static void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)
{
struct optc *optc1 = DCN10TG_FROM_TG(optc);

--
2.40.0

2023-03-29 19:04:55

by Hamza Mahfooz

Subject: Re: [PATCH v2 2/2] drm/amd/display: Mark function 'optc3_wait_drr_doublebuffer_pending_clear' as static

On 3/29/23 14:05, Caio Novais wrote:
> Compiling AMD GPU drivers displays a warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:294:6: warning: no previous prototype for ‘optc3_wait_drr_doublebuffer_pending_clear’ [-Wmissing-prototypes]
>
> Get rid of it by marking the function as static
>
> Signed-off-by: Caio Novais <[email protected]>

Applied, thanks!

> ---
> drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> index 08b92715e2e6..c95f000b63b2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> @@ -291,7 +291,7 @@ static void optc3_set_timing_double_buffer(struct timing_generator *optc, bool e
> OTG_DRR_TIMING_DBUF_UPDATE_MODE, mode);
> }
>
> -void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)
> +static void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)
> {
> struct optc *optc1 = DCN10TG_FROM_TG(optc);
>
--
Hamza