2023-03-30 20:43:14

by Tom Rix

Subject: [PATCH] scsi: qedf: remove unused num_handled variable

clang with W=1 reports
drivers/scsi/qedf/qedf_main.c:2227:6: error: variable
'num_handled' set but not used [-Werror,-Wunused-but-set-variable]
int num_handled = 0;
^
This variable is not used so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/scsi/qedf/qedf_main.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index e7f2560b9f7d..3b64de81ea0d 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -2224,7 +2224,6 @@ static bool qedf_process_completions(struct qedf_fastpath *fp)
u16 prod_idx;
struct fcoe_cqe *cqe;
struct qedf_io_work *io_work;
- int num_handled = 0;
unsigned int cpu;
struct qedf_ioreq *io_req = NULL;
u16 xid;
@@ -2247,7 +2246,6 @@ static bool qedf_process_completions(struct qedf_fastpath *fp)

while (new_cqes) {
fp->completions++;
- num_handled++;
cqe = &que->cq[que->cq_cons_idx];

comp_type = (cqe->cqe_data >> FCOE_CQE_CQE_TYPE_SHIFT) &
--
2.27.0

2023-04-03 02:11:58

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qedf: remove unused num_handled variable

Tom,

> clang with W=1 reports
> drivers/scsi/qedf/qedf_main.c:2227:6: error: variable
> 'num_handled' set but not used [-Werror,-Wunused-but-set-variable]
> int num_handled = 0;
> ^
> This variable is not used so remove it.

Applied to 6.4/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2023-04-12 02:06:04

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qedf: remove unused num_handled variable

On Thu, 30 Mar 2023 16:34:44 -0400, Tom Rix wrote:

> clang with W=1 reports
> drivers/scsi/qedf/qedf_main.c:2227:6: error: variable
> 'num_handled' set but not used [-Werror,-Wunused-but-set-variable]
> int num_handled = 0;
> ^
> This variable is not used so remove it.
>
> [...]

Applied to 6.4/scsi-queue, thanks!

[1/1] scsi: qedf: remove unused num_handled variable
https://git.kernel.org/mkp/scsi/c/7866e03b9825

--
Martin K. Petersen Oracle Linux Engineering