2023-04-03 14:11:13

by Nipun Gupta

[permalink] [raw]
Subject: [PATCH] cdx: change struct bus_type for sysfs rescan callback as constant

As store prototype in struct bus_attribute has been updated
to have bus_type as constant, change the CDX sysfs entries to
follow the same.

Signed-off-by: Nipun Gupta <[email protected]>
---

The bus attributes are marked as constant in patch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=75cff725d9566699a670a02b3cfd1c6e9e9ed53e

drivers/cdx/cdx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c
index 67c32cb2c006..38511fd36325 100644
--- a/drivers/cdx/cdx.c
+++ b/drivers/cdx/cdx.c
@@ -363,7 +363,7 @@ static struct attribute *cdx_dev_attrs[] = {
};
ATTRIBUTE_GROUPS(cdx_dev);

-static ssize_t rescan_store(struct bus_type *bus,
+static ssize_t rescan_store(const struct bus_type *bus,
const char *buf, size_t count)
{
struct cdx_controller *cdx;
--
2.17.1


2023-04-03 16:18:50

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] cdx: change struct bus_type for sysfs rescan callback as constant

On Mon, Apr 03, 2023 at 07:34:16PM +0530, Nipun Gupta wrote:
> As store prototype in struct bus_attribute has been updated
> to have bus_type as constant, change the CDX sysfs entries to
> follow the same.
>
> Signed-off-by: Nipun Gupta <[email protected]>
> ---
>
> The bus attributes are marked as constant in patch:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=75cff725d9566699a670a02b3cfd1c6e9e9ed53e
>
> drivers/cdx/cdx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c
> index 67c32cb2c006..38511fd36325 100644
> --- a/drivers/cdx/cdx.c
> +++ b/drivers/cdx/cdx.c
> @@ -363,7 +363,7 @@ static struct attribute *cdx_dev_attrs[] = {
> };
> ATTRIBUTE_GROUPS(cdx_dev);
>
> -static ssize_t rescan_store(struct bus_type *bus,
> +static ssize_t rescan_store(const struct bus_type *bus,
> const char *buf, size_t count)
> {
> struct cdx_controller *cdx;
> --
> 2.17.1
>

Thanks, I'll hold onto this for the -rc1 merge.

greg k-h