2023-04-04 00:42:30

by Tom Rix

Subject: [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static

smatch reports
drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
'mode_state_machine' was not declared. Should it be static?

This variable is only used in one file so it should be static.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/cpufreq/amd-pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 6f4b8040d46c..5a3d4aa0f45a 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
return 0;
}

-cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
+static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
[AMD_PSTATE_DISABLE] = {
[AMD_PSTATE_DISABLE] = NULL,
[AMD_PSTATE_PASSIVE] = amd_pstate_register_driver,
--
2.27.0

2023-04-04 12:35:24

by Wyes Karny

Subject: Re: [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static

On 03 Apr 20:33, Tom Rix wrote:
> smatch reports
> drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
> 'mode_state_machine' was not declared. Should it be static?
>
> This variable is only used in one file so it should be static.
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Wyes Karny <[email protected]>
Tested-by: Wyes Karny <[email protected]>

> ---
> drivers/cpufreq/amd-pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6f4b8040d46c..5a3d4aa0f45a 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
> return 0;
> }
>
> -cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> +static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> [AMD_PSTATE_DISABLE] = {
> [AMD_PSTATE_DISABLE] = NULL,
> [AMD_PSTATE_PASSIVE] = amd_pstate_register_driver,
> --
> 2.27.0
>

2023-04-05 04:40:47

by Dhruva Gole

Subject: Re: [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static

On 04/04/23 06:03, Tom Rix wrote:
> smatch reports
> drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
> 'mode_state_machine' was not declared. Should it be static?
>
> This variable is only used in one file so it should be static.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---

You might want to use the Fixes: commit ("")
tag? It will help people to pick the patch while
back-porting fixes to older kernels.'

For example:
https://lore.kernel.org/all/[email protected]/

Fixes: 0651a730924b ("gpio: davinci: Add support for system
suspend/resume PM")

Otherwise,

Reviewed-by: Dhruva Gole <[email protected]>

> drivers/cpufreq/amd-pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6f4b8040d46c..5a3d4aa0f45a 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
> return 0;
> }
>
> -cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> +static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> [AMD_PSTATE_DISABLE] = {
> [AMD_PSTATE_DISABLE] = NULL,
> [AMD_PSTATE_PASSIVE] = amd_pstate_register_driver,

--
Thanks and Regards,
Dhruva Gole

2023-04-11 18:50:35

by Rafael J. Wysocki

Subject: Re: [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static

On Tue, Apr 4, 2023 at 2:33 AM Tom Rix <[email protected]> wrote:
>
> smatch reports
> drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
> 'mode_state_machine' was not declared. Should it be static?
>
> This variable is only used in one file so it should be static.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/cpufreq/amd-pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6f4b8040d46c..5a3d4aa0f45a 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
> return 0;
> }
>
> -cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> +static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> [AMD_PSTATE_DISABLE] = {
> [AMD_PSTATE_DISABLE] = NULL,
> [AMD_PSTATE_PASSIVE] = amd_pstate_register_driver,
> --

Applied as 6.4 material (under edited subject), thanks!