2023-04-04 01:52:04

by Tom Rix

Subject: [PATCH] iio: dac: set varaiable max5522_channels storage-class-specifier to static

smatch reports
drivers/iio/dac/max5522.c:55:28: warning: symbol
'max5522_channels' was not declared. Should it be static?

This variable is only used in one file so it should be static.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/iio/dac/max5522.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/max5522.c b/drivers/iio/dac/max5522.c
index 00ba4e98fb9c..05034a306597 100644
--- a/drivers/iio/dac/max5522.c
+++ b/drivers/iio/dac/max5522.c
@@ -52,7 +52,7 @@ struct max5522_state {
} \
}

-const struct iio_chan_spec max5522_channels[] = {
+static const struct iio_chan_spec max5522_channels[] = {
MAX5522_CHANNEL(0),
MAX5522_CHANNEL(1),
};
--
2.27.0

2023-04-04 06:53:37

by Nuno Sá

Subject: Re: [PATCH] iio: dac: set varaiable max5522_channels storage-class-specifier to static

On Mon, 2023-04-03 at 21:38 -0400, Tom Rix wrote:
> smatch reports
> drivers/iio/dac/max5522.c:55:28: warning: symbol
>   'max5522_channels' was not declared. Should it be static?
>
> This variable is only used in one file so it should be static.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---

Reviewed-by: Nuno Sa <[email protected]>

2023-04-07 17:54:55

by Jonathan Cameron

Subject: Re: [PATCH] iio: dac: set varaiable max5522_channels storage-class-specifier to static

On Tue, 04 Apr 2023 08:43:32 +0200
Nuno Sá <[email protected]> wrote:

> On Mon, 2023-04-03 at 21:38 -0400, Tom Rix wrote:
> > smatch reports
> > drivers/iio/dac/max5522.c:55:28: warning: symbol
> >   'max5522_channels' was not declared. Should it be static?
> >
> > This variable is only used in one file so it should be static.
> >
> > Signed-off-by: Tom Rix <[email protected]>
> > ---
>
> Reviewed-by: Nuno Sa <[email protected]>
>
>

Applied to the togreg branch of iio.git (pushed out initially as testing)
with tweak in patch title to fix "variable"

Thanks,

Jonathan