2023-04-08 17:28:22

by Sumitra Sharma

Subject: [PATCH] staging: rtl8192e: Fix logical operator continuations

Fix logical operator continuation as suggested by Linux kernel
coding-style. Check reported by checkpatch:

CHECK: Logical continuations should be on the previous line

Signed-off-by: Sumitra Sharma <[email protected]>
---
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
index 5a1cd22f5e25..58ed394202ae 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
@@ -209,8 +209,8 @@ void rtl92e_leisure_ps_enter(struct net_device *dev)
&priv->rtllib->pwr_save_ctrl;

if (!((priv->rtllib->iw_mode == IW_MODE_INFRA) &&
- (priv->rtllib->state == RTLLIB_LINKED))
- || (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
+ (priv->rtllib->state == RTLLIB_LINKED)) ||
+ (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
(priv->rtllib->iw_mode == IW_MODE_MASTER))
return;

--
2.25.1

2023-04-11 00:07:45

by Alison Schofield

Subject: Re: [PATCH] staging: rtl8192e: Fix logical operator continuations

On Sat, Apr 08, 2023 at 10:18:03AM -0700, Sumitra Sharma wrote:
> Fix logical operator continuation as suggested by Linux kernel
> coding-style. Check reported by checkpatch:
>
> CHECK: Logical continuations should be on the previous line
>
> Signed-off-by: Sumitra Sharma <[email protected]>

Hi Sumitra,

That commit message can be explicit, like "Move logical operator
to previous line"

Alison


> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> index 5a1cd22f5e25..58ed394202ae 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> @@ -209,8 +209,8 @@ void rtl92e_leisure_ps_enter(struct net_device *dev)
> &priv->rtllib->pwr_save_ctrl;
>
> if (!((priv->rtllib->iw_mode == IW_MODE_INFRA) &&
> - (priv->rtllib->state == RTLLIB_LINKED))
> - || (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
> + (priv->rtllib->state == RTLLIB_LINKED)) ||
> + (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
> (priv->rtllib->iw_mode == IW_MODE_MASTER))
> return;
>
> --
> 2.25.1
>

2023-04-11 05:36:19

by Sumitra Sharma

Subject: Re: [PATCH] staging: rtl8192e: Fix logical operator continuations

On Mon, Apr 10, 2023 at 05:07:12PM -0700, Alison Schofield wrote:
> On Sat, Apr 08, 2023 at 10:18:03AM -0700, Sumitra Sharma wrote:
> > Fix logical operator continuation as suggested by Linux kernel
> > coding-style. Check reported by checkpatch:
> >
> > CHECK: Logical continuations should be on the previous line
> >
> > Signed-off-by: Sumitra Sharma <[email protected]>
>
> Hi Sumitra,
>
> That commit message can be explicit, like "Move logical operator
> to previous line"
>

Hi Alison

Okay I will change it. Thank you.

Regards
Sumitra

> Alison
>
>
> > ---
> > drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> > index 5a1cd22f5e25..58ed394202ae 100644
> > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
> > @@ -209,8 +209,8 @@ void rtl92e_leisure_ps_enter(struct net_device *dev)
> > &priv->rtllib->pwr_save_ctrl;
> >
> > if (!((priv->rtllib->iw_mode == IW_MODE_INFRA) &&
> > - (priv->rtllib->state == RTLLIB_LINKED))
> > - || (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
> > + (priv->rtllib->state == RTLLIB_LINKED)) ||
> > + (priv->rtllib->iw_mode == IW_MODE_ADHOC) ||
> > (priv->rtllib->iw_mode == IW_MODE_MASTER))
> > return;
> >
> > --
> > 2.25.1
> >