2023-04-11 06:35:24

by Qing Zhang

Subject: [PATCH] Mips: Fix _CONST64_(x) as unsigned

Addresses should all be of unsigned type to avoid unnecessary conversions.

Signed-off-by: Qing Zhang <[email protected]>
---
arch/mips/include/asm/addrspace.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/include/asm/addrspace.h b/arch/mips/include/asm/addrspace.h
index 59a48c60a065..75d36115a25e 100644
--- a/arch/mips/include/asm/addrspace.h
+++ b/arch/mips/include/asm/addrspace.h
@@ -25,9 +25,9 @@
#define _ATYPE32_ int
#define _ATYPE64_ __s64
#ifdef CONFIG_64BIT
-#define _CONST64_(x) x ## L
+#define _CONST64_(x) x ## UL
#else
-#define _CONST64_(x) x ## LL
+#define _CONST64_(x) x ## ULL
#endif
#endif

--
2.20.1

2023-04-14 08:15:19

by Jiaxun Yang

Subject: Re: [PATCH] Mips: Fix _CONST64_(x) as unsigned

> 2023年4月11日 07:31，Qing Zhang <[email protected]> 写道：
>
> Addresses should all be of unsigned type to avoid unnecessary conversions.

It’s defined as signed for a reason. To keep consistent with 32-bit address, which
Is sign-extended on 64bit systems.

Thanks
Jiaxun

>
> Signed-off-by: Qing Zhang <[email protected]>
> ---
> arch/mips/include/asm/addrspace.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/include/asm/addrspace.h b/arch/mips/include/asm/addrspace.h
> index 59a48c60a065..75d36115a25e 100644
> --- a/arch/mips/include/asm/addrspace.h
> +++ b/arch/mips/include/asm/addrspace.h
> @@ -25,9 +25,9 @@
> #define _ATYPE32_ int
> #define _ATYPE64_ __s64
> #ifdef CONFIG_64BIT
> -#define _CONST64_(x) x ## L
> +#define _CONST64_(x) x ## UL
> #else
> -#define _CONST64_(x) x ## LL
> +#define _CONST64_(x) x ## ULL
> #endif
> #endif
>
> --
> 2.20.1
>