2023-04-13 16:41:06

by 李扬韬

[permalink] [raw]
Subject: [PATCH] quota: mark PRINT_QUOTA_WARNING as BROKEN

User should use notification via netlink socket. PRINT_QUOTA_WARNING is
deprecated since commit 8e8934695dfd ("quota: send messages
via netlink"), so mark it as BROKEN.

Signed-off-by: Yangtao Li <[email protected]>
---
fs/quota/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig
index d5a85a8062d0..10e9a0efc6c2 100644
--- a/fs/quota/Kconfig
+++ b/fs/quota/Kconfig
@@ -28,7 +28,7 @@ config QUOTA_NETLINK_INTERFACE

config PRINT_QUOTA_WARNING
bool "Print quota warnings to console (OBSOLETE)"
- depends on QUOTA
+ depends on QUOTA && BROKEN
default y
help
If you say Y here, quota warnings (about exceeding softlimit, reaching
--
2.35.1


2023-04-14 11:29:34

by Jan Kara

[permalink] [raw]
Subject: Re: [PATCH] quota: mark PRINT_QUOTA_WARNING as BROKEN

On Fri 14-04-23 00:38:32, Yangtao Li wrote:
> User should use notification via netlink socket. PRINT_QUOTA_WARNING is
> deprecated since commit 8e8934695dfd ("quota: send messages
> via netlink"), so mark it as BROKEN.
>
> Signed-off-by: Yangtao Li <[email protected]>

Thanks. I've merged the patch (with somewhat updated changelog) to my tree.

Honza

> ---
> fs/quota/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig
> index d5a85a8062d0..10e9a0efc6c2 100644
> --- a/fs/quota/Kconfig
> +++ b/fs/quota/Kconfig
> @@ -28,7 +28,7 @@ config QUOTA_NETLINK_INTERFACE
>
> config PRINT_QUOTA_WARNING
> bool "Print quota warnings to console (OBSOLETE)"
> - depends on QUOTA
> + depends on QUOTA && BROKEN
> default y
> help
> If you say Y here, quota warnings (about exceeding softlimit, reaching
> --
> 2.35.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR