2023-04-18 06:50:06

by Jiri Slaby

Subject: [PATCH v2] ACPI: video: Add backlight=native DMI quirk for Lenovo Ideapad Z470

The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using
acpi_video for backlight control. But this is not functional on this
model.

Add a DMI quirk to use the native backlight interface which works.

Link: https://bugzilla.suse.com/show_bug.cgi?id=1208724
Signed-off-by: Jiri Slaby (SUSE) <[email protected]>
Reviewed-by: Hans de Goede <[email protected]>
Cc: Rafael J. Wysocki <[email protected]>
---

Notes:
[v2] fix authorship

drivers/acpi/video_detect.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 69ef2d9710c2..af5cea005f54 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"),
},
},
+ {
+ /* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */
+ .callback = video_detect_force_native,
+ /* Lenovo Ideapad Z470 */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"),
+ },
+ },
{
/* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */
.callback = video_detect_force_native,
--
2.40.0

2023-07-17 10:35:30

by Jiri Slaby

Subject: Re: [PATCH v2] ACPI: video: Add backlight=native DMI quirk for Lenovo Ideapad Z470

Hi,

this has been likely lost. Should I resend?

Thanks.

On 18. 04. 23, 8:42, Jiri Slaby (SUSE) wrote:
> The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using
> acpi_video for backlight control. But this is not functional on this
> model.
>
> Add a DMI quirk to use the native backlight interface which works.
>
> Link: https://bugzilla.suse.com/show_bug.cgi?id=1208724
> Signed-off-by: Jiri Slaby (SUSE) <[email protected]>
> Reviewed-by: Hans de Goede <[email protected]>
> Cc: Rafael J. Wysocki <[email protected]>
> ---
>
> Notes:
> [v2] fix authorship
>
> drivers/acpi/video_detect.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 69ef2d9710c2..af5cea005f54 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
> DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"),
> },
> },
> + {
> + /* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */
> + .callback = video_detect_force_native,
> + /* Lenovo Ideapad Z470 */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"),
> + },
> + },
> {
> /* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */
> .callback = video_detect_force_native,

--
js
suse labs

2023-07-17 13:12:25

by Rafael J. Wysocki

Subject: Re: [PATCH v2] ACPI: video: Add backlight=native DMI quirk for Lenovo Ideapad Z470

On Mon, Jul 17, 2023 at 12:20 PM Jiri Slaby <[email protected]> wrote:
>
> Hi,
>
> this has been likely lost.

Yes, it has, sorry about that.

It's better to CC ACPI-related patches to [email protected],
so they are included in my normal flow, to avoid such events.

> Should I resend?

No need, I've just applied it as 6.6 material.

Thanks!