[permalink] [raw]

Subject: Re: [PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt

On 4/18/23 10:43, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> Add the "Amlogic" vendor name to the CONFIG_PCI_MESON Kconfig prompt to
> match other PCIe drivers. Capitalize "Meson" to match other Meson Kconfig
> prompts.

Did you mean, do not capitalize "Meson" or did you intend to preserve
the previous hunk that had "Meson" capitalized?
--
Florian

2023-04-18 18:43:27

by Bjorn Helgaas

[permalink] [raw]

Subject: Re: [PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt

On Tue, Apr 18, 2023 at 11:10:39AM -0700, Florian Fainelli wrote:
> On 4/18/23 10:43, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <[email protected]>
> >
> > Add the "Amlogic" vendor name to the CONFIG_PCI_MESON Kconfig prompt to
> > match other PCIe drivers. Capitalize "Meson" to match other Meson Kconfig
> > prompts.
>
> Did you mean, do not capitalize "Meson" or did you intend to preserve the
> previous hunk that had "Meson" capitalized?

I made it match other Meson prompts:

arch/arm/mach-meson/Kconfig- bool "Amlogic Meson6 (8726MX) SoCs support"
drivers/char/hw_random/Kconfig- tristate "Amlogic Meson Random Number Generator support"
drivers/clk/meson/Kconfig- bool "Meson8 SoC Clock controller support"
drivers/gpu/drm/meson/Kconfig- tristate "DRM Support for Amlogic Meson Display Controller"
drivers/i2c/busses/Kconfig- tristate "Amlogic Meson I2C controller"
drivers/iio/adc/Kconfig- tristate "Amlogic Meson SAR ADC driver"
drivers/media/cec/platform/Kconfig- tristate "Amlogic Meson AO CEC driver"

So I guess could have described as "style Meson with initial cap only
instead of all caps" or something.

Bjorn

2023-04-19 07:51:58

by Michal Simek

[permalink] [raw]

Subject: Re: [PATCH 3/7] PCI: xilinx-nwl: Add 'Xilinx' to Kconfig prompt

On 4/18/23 19:43, Bjorn Helgaas wrote:
>
> From: Bjorn Helgaas <[email protected]>
>
> Add the "Xilinx" vendor name to the CONFIG_PCIE_XILINX_NWL Kconfig prompt
> so it matches other drivers. Rename from "PCIe Core" to "PCIe controller".
>
> Signed-off-by: Bjorn Helgaas <[email protected]>
> Cc: Michal Simek <[email protected]>
> ---
> drivers/pci/controller/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 8b1f9a3f83ea..5875587d8b59 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -28,7 +28,7 @@ config PCI_AARDVARK
> 3700 SoC.
>
> config PCIE_XILINX_NWL
> - bool "NWL PCIe Core"
> + bool "Xilinx NWL PCIe controller"
> depends on ARCH_ZYNQMP || COMPILE_TEST
> depends on PCI_MSI
> help
> --
> 2.25.1
>

Acked-by: Michal Simek <[email protected]>

Thanks,
Michal

2023-04-19 18:19:03

by Wei Liu

[permalink] [raw]

Subject: Re: [PATCH 2/7] PCI: hv: Add 'Microsoft' to Kconfig prompt

On Tue, Apr 18, 2023 at 12:43:31PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> Add the "Microsoft" vendor name to the CONFIG_PCI_HYPERV_INTERFACE Kconfig
> prompt so it matches other PCIe drivers and other Hyper-V prompts.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>
> Cc: K. Y. Srinivasan <[email protected]>
> Cc: Haiyang Zhang <[email protected]>
> Cc: Wei Liu <[email protected]>
> Cc: Dexuan Cui <[email protected]>

Acked-by: Wei Liu <[email protected]>

> ---
> drivers/pci/controller/Kconfig | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 42654035654a..8b1f9a3f83ea 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -285,11 +285,12 @@ config PCIE_BRCMSTB
> Broadcom STB based SoCs, like the Raspberry Pi 4.
>
> config PCI_HYPERV_INTERFACE
> - tristate "Hyper-V PCI Interface"
> + tristate "Microsoft Hyper-V PCI Interface"
> depends on ((X86 && X86_64) || ARM64) && HYPERV && PCI_MSI
> help
> - The Hyper-V PCI Interface is a helper driver allows other drivers to
> - have a common interface with the Hyper-V PCI frontend driver.
> + The Hyper-V PCI Interface is a helper driver that allows other
> + drivers to have a common interface with the Hyper-V PCI frontend
> + driver.
>
> config PCI_LOONGSON
> bool "LOONGSON PCI Controller"
> --
> 2.25.1
>

2023-04-19 18:58:36

by Florian Fainelli

[permalink] [raw]

Subject: Re: [PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt

On 4/18/23 11:40, Bjorn Helgaas wrote:
> On Tue, Apr 18, 2023 at 11:10:39AM -0700, Florian Fainelli wrote:
>> On 4/18/23 10:43, Bjorn Helgaas wrote:
>>> From: Bjorn Helgaas <[email protected]>
>>>
>>> Add the "Amlogic" vendor name to the CONFIG_PCI_MESON Kconfig prompt to
>>> match other PCIe drivers. Capitalize "Meson" to match other Meson Kconfig
>>> prompts.
>>
>> Did you mean, do not capitalize "Meson" or did you intend to preserve the
>> previous hunk that had "Meson" capitalized?
>
> I made it match other Meson prompts:
>
> arch/arm/mach-meson/Kconfig- bool "Amlogic Meson6 (8726MX) SoCs support"
> drivers/char/hw_random/Kconfig- tristate "Amlogic Meson Random Number Generator support"
> drivers/clk/meson/Kconfig- bool "Meson8 SoC Clock controller support"
> drivers/gpu/drm/meson/Kconfig- tristate "DRM Support for Amlogic Meson Display Controller"
> drivers/i2c/busses/Kconfig- tristate "Amlogic Meson I2C controller"
> drivers/iio/adc/Kconfig- tristate "Amlogic Meson SAR ADC driver"
> drivers/media/cec/platform/Kconfig- tristate "Amlogic Meson AO CEC driver"
>
> So I guess could have described as "style Meson with initial cap only
> instead of all caps" or something.

This is fine, I was just reading it wrong, as meaning all capital
letters. Thanks.
--
Florian

2023-04-20 19:48:11

by Bjorn Helgaas

[permalink] [raw]

Subject: Re: [PATCH 0/7] PCI: Tidy controller Kconfig

On Tue, Apr 18, 2023 at 12:43:29PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> Use vendor name in all native controller Kconfig entries. Use consistent
> prompt language. Sort entries by vendor name so they appear in alpha order
> in menuconfig.
>
> Bjorn Helgaas (7):
> PCI: meson: Add 'Amlogic' to Kconfig prompt
> PCI: hv: Add 'Microsoft' to Kconfig prompt
> PCI: xilinx-nwl: Add 'Xilinx' to Kconfig prompt
> PCI: Use consistent controller Kconfig menu entry language
> PCI: Sort controller Kconfig entries by vendor
> PCI: dwc: Sort Kconfig entries by vendor
> PCI: mobiveil: Sort Kconfig entries by vendor
>
> drivers/pci/controller/Kconfig | 463 ++++++++++-----------
> drivers/pci/controller/cadence/Kconfig | 10 +-
> drivers/pci/controller/dwc/Kconfig | 518 ++++++++++++------------
> drivers/pci/controller/mobiveil/Kconfig | 19 +-
> 4 files changed, 506 insertions(+), 504 deletions(-)

I applied these to pci/controller/kconfig for v6.4.