2023-04-25 14:11:16

by Cai Huoqing

Subject: [PATCH] rhashtable-test: Make use of rhashtable_walk_peek

Add an example usage of rhashtable_walk_peek to test_bucket_stats.

Signed-off-by: Cai Huoqing <[email protected]>
---
lib/test_rhashtable.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c
index c20f6cb4bf55..b1c3316b9bde 100644
--- a/lib/test_rhashtable.c
+++ b/lib/test_rhashtable.c
@@ -177,6 +177,7 @@ static void test_bucket_stats(struct rhashtable *ht, unsigned int entries)
unsigned int total = 0, chain_len = 0;
struct rhashtable_iter hti;
struct rhash_head *pos;
+ struct test_obj *obj;

rhashtable_walk_enter(ht, &hti);
rhashtable_walk_start(&hti);
@@ -192,6 +193,13 @@ static void test_bucket_stats(struct rhashtable *ht, unsigned int entries)
break;
}

+ /* Here's an example usage of rhashtable_walk_peek */
+ obj = rhashtable_walk_peek(&hti);
+ if (!obj) {
+ pr_warn("Test failed: rhashtable_walk_peek() error\n");
+ break;
+ }
+
total++;
}

--
2.34.1

2023-05-03 10:20:47

by Herbert Xu

Subject: Re: [PATCH] rhashtable-test: Make use of rhashtable_walk_peek

On Tue, Apr 25, 2023 at 09:56:17PM +0800, Cai Huoqing wrote:
> Add an example usage of rhashtable_walk_peek to test_bucket_stats.
>
> Signed-off-by: Cai Huoqing <[email protected]>
> ---
> lib/test_rhashtable.c | 8 ++++++++
> 1 file changed, 8 insertions(+)

This is supposed to be testing rhashtable code, it's not meant
to be an example of how to use the API.

> @@ -192,6 +193,13 @@ static void test_bucket_stats(struct rhashtable *ht, unsigned int entries)
> break;
> }
>
> + /* Here's an example usage of rhashtable_walk_peek */
> + obj = rhashtable_walk_peek(&hti);
> + if (!obj) {
> + pr_warn("Test failed: rhashtable_walk_peek() error\n");
> + break;
> + }
> +

What is this meant to test?

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt