2023-04-28 06:33:41

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] soc: ti: smartreflex: Use devm_platform_ioremap_resource()

Convert platform_get_resource(),devm_ioremap_resource() to a single
call to devm_platform_ioremap_resource(), as this is exactly what this
function does.

Signed-off-by: Yang Li <[email protected]>
---
drivers/soc/ti/smartreflex.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c
index da7898239a46..62b2f1464e46 100644
--- a/drivers/soc/ti/smartreflex.c
+++ b/drivers/soc/ti/smartreflex.c
@@ -815,7 +815,6 @@ static int omap_sr_probe(struct platform_device *pdev)
{
struct omap_sr *sr_info;
struct omap_sr_data *pdata = pdev->dev.platform_data;
- struct resource *mem;
struct dentry *nvalue_dir;
int i, ret = 0;

@@ -835,8 +834,7 @@ static int omap_sr_probe(struct platform_device *pdev)
return -EINVAL;
}

- mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- sr_info->base = devm_ioremap_resource(&pdev->dev, mem);
+ sr_info->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(sr_info->base))
return PTR_ERR(sr_info->base);

--
2.20.1.7.g153144c


2023-04-28 10:20:15

by Dhruva Gole

[permalink] [raw]
Subject: Re: [PATCH -next] soc: ti: smartreflex: Use devm_platform_ioremap_resource()

Hi,

On 28/04/23 11:58, Yang Li wrote:
> Convert platform_get_resource(),devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource(), as this is exactly what this
> function does.
>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/soc/ti/smartreflex.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c
> index da7898239a46..62b2f1464e46 100644
> --- a/drivers/soc/ti/smartreflex.c
> +++ b/drivers/soc/ti/smartreflex.c
> @@ -815,7 +815,6 @@ static int omap_sr_probe(struct platform_device *pdev)
> {
> struct omap_sr *sr_info;
> struct omap_sr_data *pdata = pdev->dev.platform_data;
> - struct resource *mem;
> struct dentry *nvalue_dir;
> int i, ret = 0;
>
> @@ -835,8 +834,7 @@ static int omap_sr_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - sr_info->base = devm_ioremap_resource(&pdev->dev, mem);
> + sr_info->base = devm_platform_ioremap_resource(pdev, 0);


Reviewed-by: Dhruva Gole <[email protected]>

> if (IS_ERR(sr_info->base))
> return PTR_ERR(sr_info->base);
>

--
Thanks and Regards,
Dhruva Gole

2023-05-17 18:20:56

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH -next] soc: ti: smartreflex: Use devm_platform_ioremap_resource()

Hi Yang Li,

On Fri, 28 Apr 2023 14:28:25 +0800, Yang Li wrote:
> Convert platform_get_resource(),devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource(), as this is exactly what this
> function does.
>
>

I have applied the following to branch ti-drivers-soc-next on [1].
Thank you!

[1/1] soc: ti: smartreflex: Use devm_platform_ioremap_resource()
commit: 9f60d9d310b94c5869a5b6a2f1707b90bd60245c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D