2023-05-05 06:10:09

by Jiapeng Chong

Subject: [PATCH] media: nxp: remove unneeded semicolon

No functional modification involved.

./drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c:226:2-3: Unneeded semicolon.

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4868
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
index b5ffde46f31b..f7447b2f4d77 100644
--- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
+++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
@@ -223,7 +223,7 @@ static int mxc_isi_crossbar_init_cfg(struct v4l2_subdev *sd,
route->sink_pad = i;
route->source_pad = i + xbar->num_sinks;
route->flags = V4L2_SUBDEV_ROUTE_FL_ACTIVE;
- };
+ }

routing.num_routes = xbar->num_sources;
routing.routes = routes;
--
2.20.1.7.g153144c

2023-05-05 10:06:04

by Laurent Pinchart

Subject: Re: [PATCH] media: nxp: remove unneeded semicolon

Hi Jiapeng,

Thank you for the patch.

On Fri, May 05, 2023 at 02:06:17PM +0800, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c:226:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4868
> Signed-off-by: Jiapeng Chong <[email protected]>

I'll update the subject line to

media: nxp: imx8-isi: Remove unneeded semicolon

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> index b5ffde46f31b..f7447b2f4d77 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> @@ -223,7 +223,7 @@ static int mxc_isi_crossbar_init_cfg(struct v4l2_subdev *sd,
> route->sink_pad = i;
> route->source_pad = i + xbar->num_sinks;
> route->flags = V4L2_SUBDEV_ROUTE_FL_ACTIVE;
> - };
> + }
>
> routing.num_routes = xbar->num_sources;
> routing.routes = routes;

--
Regards,

Laurent Pinchart