2023-05-05 09:13:15

by ye.xingchen

Subject: [PATCH] net: socket: Use fdget() and fdput()

From: Ye Xingchen <[email protected]>

By using the fdget function, the socket object, can be quickly obtained
from the process's file descriptor table without the need to obtain the
file descriptor first before passing it as a parameter to the fget
function.

Signed-off-by: Ye Xingchen <[email protected]>
---
net/socket.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/net/socket.c b/net/socket.c
index a7b4b37d86df..84daba774432 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -528,19 +528,18 @@ EXPORT_SYMBOL(sock_from_file);

struct socket *sockfd_lookup(int fd, int *err)
{
- struct file *file;
+ struct fd f = fdget(fd);
struct socket *sock;

- file = fget(fd);
- if (!file) {
+ if (!f.file) {
*err = -EBADF;
return NULL;
}

- sock = sock_from_file(file);
+ sock = sock_from_file(f.file);
if (!sock) {
*err = -ENOTSOCK;
- fput(file);
+ fdput(f);
}
return sock;
}
--
2.25.1

2023-05-05 10:56:16

by Eric Dumazet

Subject: Re: [PATCH] net: socket: Use fdget() and fdput()

On Fri, May 5, 2023 at 11:06 AM <[email protected]> wrote:
>
> From: Ye Xingchen <[email protected]>
>
> By using the fdget function, the socket object, can be quickly obtained
> from the process's file descriptor table without the need to obtain the
> file descriptor first before passing it as a parameter to the fget
> function.
>

net-next is currently closed.

There are good reasons we have sockfd_lookup() and sockfd_lookup_light(),
you probably should take a deeper look at the difference between them.



> Signed-off-by: Ye Xingchen <[email protected]>
> ---
> net/socket.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index a7b4b37d86df..84daba774432 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -528,19 +528,18 @@ EXPORT_SYMBOL(sock_from_file);
>
> struct socket *sockfd_lookup(int fd, int *err)
> {
> - struct file *file;
> + struct fd f = fdget(fd);
> struct socket *sock;
>
> - file = fget(fd);
> - if (!file) {
> + if (!f.file) {
> *err = -EBADF;
> return NULL;
> }
>
> - sock = sock_from_file(file);
> + sock = sock_from_file(f.file);
> if (!sock) {
> *err = -ENOTSOCK;
> - fput(file);
> + fdput(f);
> }
> return sock;
> }
> --
> 2.25.1

2023-05-11 05:29:43

by Al Viro

Subject: Re: [PATCH] net: socket: Use fdget() and fdput()

On Fri, May 05, 2023 at 05:06:41PM +0800, [email protected] wrote:
> By using the fdget function, the socket object, can be quickly obtained
> from the process's file descriptor table without the need to obtain the
> file descriptor first before passing it as a parameter to the fget
> function.

> struct socket *sockfd_lookup(int fd, int *err)
> {
> - struct file *file;
> + struct fd f = fdget(fd);
> struct socket *sock;
>
> - file = fget(fd);
> - if (!file) {
> + if (!f.file) {
> *err = -EBADF;
> return NULL;
> }
>
> - sock = sock_from_file(file);
> + sock = sock_from_file(f.file);
> if (!sock) {
> *err = -ENOTSOCK;
> - fput(file);
> + fdput(f);
> }
> return sock;

Suppose you've got that far. If descriptor table had been shared, you've
bumped the refcount of struct file. If it hadn't been, that refcount
had remained unchanged. And there is no way for the caller of this
function to tell one outcome from another.

That can't work.