2023-05-02 04:47:03

by Thomas Weißschuh

[permalink] [raw]
Subject: [PATCH v2 2/2] power: supply: remove unneeded include of linux/leds.h

Instead of including the full linux/leds.h header file a single
forward-declaration is enough.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
include/linux/power_supply.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index a427f13c757f..dc5e17e8c919 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -14,10 +14,11 @@

#include <linux/device.h>
#include <linux/workqueue.h>
-#include <linux/leds.h>
#include <linux/spinlock.h>
#include <linux/notifier.h>

+struct led_trigger;
+
/*
* All voltages, currents, charges, energies, time and temperatures in uV,
* µA, µAh, µWh, seconds and tenths of degree Celsius unless otherwise

--
2.40.1


2023-05-08 16:40:00

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] power: supply: remove unneeded include of linux/leds.h

Hi,

On Tue, May 02, 2023 at 06:28:45AM +0200, Thomas Wei?schuh wrote:
> Instead of including the full linux/leds.h header file a single
> forward-declaration is enough.
>
> Signed-off-by: Thomas Wei?schuh <[email protected]>
> ---

Acked-by: Sebastian Reichel <[email protected]>

-- Sebastian

> include/linux/power_supply.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index a427f13c757f..dc5e17e8c919 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -14,10 +14,11 @@
>
> #include <linux/device.h>
> #include <linux/workqueue.h>
> -#include <linux/leds.h>
> #include <linux/spinlock.h>
> #include <linux/notifier.h>
>
> +struct led_trigger;
> +
> /*
> * All voltages, currents, charges, energies, time and temperatures in uV,
> * ?A, ?Ah, ?Wh, seconds and tenths of degree Celsius unless otherwise
>
> --
> 2.40.1
>


Attachments:
(No filename) (1.00 kB)
signature.asc (849.00 B)
Download all attachments