2023-05-16 20:40:28

by Arnd Bergmann

Subject: [PATCH] mfd: intel-lpss: hide suspend/resume functions in #ifdef

From: Arnd Bergmann <[email protected]>

When CONFIG_PM is disabled, the prototypes for these two functions
are not visible:

drivers/mfd/intel-lpss.c:482:5: error: no previous prototype for 'intel_lpss_suspend' [-Werror=missing-prototypes]
482 | int intel_lpss_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~
drivers/mfd/intel-lpss.c:503:5: error: no previous prototype for 'intel_lpss_resume' [-Werror=missing-prototypes]
503 | int intel_lpss_resume(struct device *dev)

Add the same #ifdef around the definition of the unused functions,
which avoids the warning and slightly reduces the code size.

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/mfd/intel-lpss.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index cfbee2cfba6b..9591b354072a 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -460,6 +460,7 @@ void intel_lpss_remove(struct device *dev)
}
EXPORT_SYMBOL_GPL(intel_lpss_remove);

+#ifdef CONFIG_PM
static int resume_lpss_device(struct device *dev, void *data)
{
if (!dev_pm_test_driver_flags(dev, DPM_FLAG_SMART_SUSPEND))
@@ -514,6 +515,7 @@ int intel_lpss_resume(struct device *dev)
return 0;
}
EXPORT_SYMBOL_GPL(intel_lpss_resume);
+#endif

static int __init intel_lpss_init(void)
{
--
2.39.2

2023-05-25 11:00:07

by Lee Jones

Subject: Re: [PATCH] mfd: intel-lpss: hide suspend/resume functions in #ifdef

On Tue, 16 May 2023, Arnd Bergmann wrote:

> From: Arnd Bergmann <[email protected]>
>
> When CONFIG_PM is disabled, the prototypes for these two functions
> are not visible:
>
> drivers/mfd/intel-lpss.c:482:5: error: no previous prototype for 'intel_lpss_suspend' [-Werror=missing-prototypes]
> 482 | int intel_lpss_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~
> drivers/mfd/intel-lpss.c:503:5: error: no previous prototype for 'intel_lpss_resume' [-Werror=missing-prototypes]
> 503 | int intel_lpss_resume(struct device *dev)
>
> Add the same #ifdef around the definition of the unused functions,
> which avoids the warning and slightly reduces the code size.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/mfd/intel-lpss.c | 2 ++
> 1 file changed, 2 insertions(+)

Applied, thanks

--
Lee Jones [李琼斯]