2023-05-19 08:39:52

by Arnd Bergmann

Subject: [PATCH] platform/x86: lenovo-yogabook: add I2C dependency

From: Arnd Bergmann <[email protected]>

The added platform_driver support fails to link when I2C core support is
not rechable:

x86_64-linux-ld: drivers/platform/x86/lenovo-yogabook.o: in function `yogabook_pdev_probe':
lenovo-yogabook.c:(.text+0x5a5): undefined reference to `i2c_bus_type'

Add a Kconfig dependency to enforce a working configuration.

Fixes: 6df1523fa0b7 ("platform/x86: lenovo-yogabook: Add platform driver support")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 9fe974d5f645..63637ea99c2f 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -125,6 +125,7 @@ config YOGABOOK
tristate "Lenovo Yoga Book tablet key driver"
depends on ACPI_WMI
depends on INPUT
+ depends on I2C
select LEDS_CLASS
select NEW_LEDS
help
--
2.39.2

2023-05-23 11:37:13

by Hans de Goede

Subject: Re: [PATCH] platform/x86: lenovo-yogabook: add I2C dependency

Hi Arnd,

On 5/19/23 10:25, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The added platform_driver support fails to link when I2C core support is
> not rechable:
>
> x86_64-linux-ld: drivers/platform/x86/lenovo-yogabook.o: in function `yogabook_pdev_probe':
> lenovo-yogabook.c:(.text+0x5a5): undefined reference to `i2c_bus_type'
>
> Add a Kconfig dependency to enforce a working configuration.
>
> Fixes: 6df1523fa0b7 ("platform/x86: lenovo-yogabook: Add platform driver support")
> Signed-off-by: Arnd Bergmann <[email protected]>

Thank you I have pushed this to pdx86/for-next now.

Regards,

Hans



> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 9fe974d5f645..63637ea99c2f 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -125,6 +125,7 @@ config YOGABOOK
> tristate "Lenovo Yoga Book tablet key driver"
> depends on ACPI_WMI
> depends on INPUT
> + depends on I2C
> select LEDS_CLASS
> select NEW_LEDS
> help