2023-05-19 22:57:28

by Jakub Kicinski

Subject: Re: [PATCH] net: macb: use correct __be32 and __be16 types

On Sat, 20 May 2023 06:19:39 +0800 Min-Hua Chen wrote:
> This patch fixes the following sparse warnings. No functional changes.
>
> Use cpu_to_be16() and cpu_to_be32() to convert constants before comparing
> them with __be16 type of psrc/pdst and __be32 type of ip4src/ip4dst.
> Apply be16_to_cpu() in GEM_BFINS().

same story as with your stmmac patch, the warning is a false positive

2023-05-20 02:02:17

by Min-Hua Chen

Subject: Re: [PATCH] net: macb: use correct __be32 and __be16 types

>On Sat, 20 May 2023 06:19:39 +0800 Min-Hua Chen wrote:
>> This patch fixes the following sparse warnings. No functional changes.
>>
>> Use cpu_to_be16() and cpu_to_be32() to convert constants before comparing
>> them with __be16 type of psrc/pdst and __be32 type of ip4src/ip4dst.
>> Apply be16_to_cpu() in GEM_BFINS().
>
>same story as with your stmmac patch, the warning is a false positive

yes, the same story and let's discuss this in the stmmac thread [1].

[1] https://lore.kernel.org/lkml/[email protected]/

thanks,
Min-Hua