From: Wei Fang <[email protected]>
The last_bdp is initialized to bdp, and both last_bdp and bdp are
not changed. That is to say that last_bdp and bdp are always equal.
So bdp can be used directly.
Signed-off-by: Wei Fang <[email protected]>
---
V2 change:
Refine the commit message to make it more clear which is suggested
by Simon Horman.
---
drivers/net/ethernet/freescale/fec_main.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 632bb4d589d7..4d37a811ae15 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3770,7 +3770,7 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
struct xdp_frame *frame)
{
unsigned int index, status, estatus;
- struct bufdesc *bdp, *last_bdp;
+ struct bufdesc *bdp;
dma_addr_t dma_addr;
int entries_free;
@@ -3782,7 +3782,6 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
/* Fill in a Tx ring entry */
bdp = txq->bd.cur;
- last_bdp = bdp;
status = fec16_to_cpu(bdp->cbd_sc);
status &= ~BD_ENET_TX_STATS;
@@ -3810,7 +3809,6 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
ebdp->cbd_esc = cpu_to_fec32(estatus);
}
- index = fec_enet_get_bd_index(last_bdp, &txq->bd);
txq->tx_skbuff[index] = NULL;
/* Make sure the updates to rest of the descriptor are performed before
@@ -3825,7 +3823,7 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep,
bdp->cbd_sc = cpu_to_fec16(status);
/* If this was the last BD in the ring, start at the beginning again. */
- bdp = fec_enet_get_nextdesc(last_bdp, &txq->bd);
+ bdp = fec_enet_get_nextdesc(bdp, &txq->bd);
/* Make sure the update to bdp are performed before txq->bd.cur. */
dma_wmb();
--
2.25.1
On Mon, May 29, 2023 at 10:26:15AM +0800, [email protected] wrote:
> From: Wei Fang <[email protected]>
>
> The last_bdp is initialized to bdp, and both last_bdp and bdp are
> not changed. That is to say that last_bdp and bdp are always equal.
> So bdp can be used directly.
>
> Signed-off-by: Wei Fang <[email protected]>
> ---
> V2 change:
> Refine the commit message to make it more clear which is suggested
> by Simon Horman.
Thanks!
Reviewed-by: Simon Horman <[email protected]>
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <[email protected]>:
On Mon, 29 May 2023 10:26:15 +0800 you wrote:
> From: Wei Fang <[email protected]>
>
> The last_bdp is initialized to bdp, and both last_bdp and bdp are
> not changed. That is to say that last_bdp and bdp are always equal.
> So bdp can be used directly.
>
> Signed-off-by: Wei Fang <[email protected]>
>
> [...]
Here is the summary with links:
- [V2,net-next] net: fec: remove last_bdp from fec_enet_txq_xmit_frame()
https://git.kernel.org/netdev/net-next/c/bc638eabfed9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html