2023-05-31 10:20:57

by Jiasheng Jiang

Subject: [PATCH] mfd: intel-lpss: Add missing check for platform_get_resource

Add the missing check for platform_get_resource and return error
if it fails.

Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
Signed-off-by: Jiasheng Jiang <[email protected]>
---
drivers/mfd/intel-lpss-acpi.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c
index a143c8dca2d9..1a6ebd3d9795 100644
--- a/drivers/mfd/intel-lpss-acpi.c
+++ b/drivers/mfd/intel-lpss-acpi.c
@@ -183,6 +183,9 @@ static int intel_lpss_acpi_probe(struct platform_device *pdev)
return -ENOMEM;

info->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!info->mem)
+ return -ENOMEM;
+
info->irq = platform_get_irq(pdev, 0);

ret = intel_lpss_probe(&pdev->dev, info);
--
2.25.1

2023-06-08 17:20:17

by Lee Jones

Subject: Re: [PATCH] mfd: intel-lpss: Add missing check for platform_get_resource

On Wed, 31 May 2023, Jiasheng Jiang wrote:

> Add the missing check for platform_get_resource and return error
> if it fails.
>
> Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
> Signed-off-by: Jiasheng Jiang <[email protected]>
> ---
> drivers/mfd/intel-lpss-acpi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c
> index a143c8dca2d9..1a6ebd3d9795 100644
> --- a/drivers/mfd/intel-lpss-acpi.c
> +++ b/drivers/mfd/intel-lpss-acpi.c
> @@ -183,6 +183,9 @@ static int intel_lpss_acpi_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> info->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!info->mem)
> + return -ENOMEM;

This does not mean we're out of memory.

Please use either -EINVAL or -ENODEV.

> +
> info->irq = platform_get_irq(pdev, 0);
>
> ret = intel_lpss_probe(&pdev->dev, info);
> --
> 2.25.1
>

--
Lee Jones [李琼斯]