2023-06-02 03:16:24

by GONG, Ruiqi

Subject: [PATCH] bpf: cleanup unused function declaration

All usage and the definition of `bpf_prog_free_linfo()` has been removed
in commit e16301fbe183 ("bpf: Simplify freeing logic in linfo and
jited_linfo"). Clean up its declaration in the header file.

Signed-off-by: GONG, Ruiqi <[email protected]>
---
include/linux/filter.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/linux/filter.h b/include/linux/filter.h
index bbce89937fde..f69114083ec7 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
@@ -874,7 +874,6 @@ void bpf_prog_free(struct bpf_prog *fp);

bool bpf_opcode_in_insntable(u8 code);

-void bpf_prog_free_linfo(struct bpf_prog *prog);
void bpf_prog_fill_jited_linfo(struct bpf_prog *prog,
const u32 *insn_to_jit_off);
int bpf_prog_alloc_jited_linfo(struct bpf_prog *prog);
--
2.25.1

2023-06-02 16:20:43

by Stanislav Fomichev

Subject: Re: [PATCH] bpf: cleanup unused function declaration

On 06/02, GONG, Ruiqi wrote:
> All usage and the definition of `bpf_prog_free_linfo()` has been removed
> in commit e16301fbe183 ("bpf: Simplify freeing logic in linfo and
> jited_linfo"). Clean up its declaration in the header file.
>
> Signed-off-by: GONG, Ruiqi <[email protected]>

Acked-by: Stanislav Fomichev <[email protected]>

> ---
> include/linux/filter.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/filter.h b/include/linux/filter.h
> index bbce89937fde..f69114083ec7 100644
> --- a/include/linux/filter.h
> +++ b/include/linux/filter.h
> @@ -874,7 +874,6 @@ void bpf_prog_free(struct bpf_prog *fp);
>
> bool bpf_opcode_in_insntable(u8 code);
>
> -void bpf_prog_free_linfo(struct bpf_prog *prog);
> void bpf_prog_fill_jited_linfo(struct bpf_prog *prog,
> const u32 *insn_to_jit_off);
> int bpf_prog_alloc_jited_linfo(struct bpf_prog *prog);
> --
> 2.25.1
>

2023-06-05 23:41:32

by Andrii Nakryiko

Subject: Re: [PATCH] bpf: cleanup unused function declaration

On Fri, Jun 2, 2023 at 9:12 AM Stanislav Fomichev <[email protected]> wrote:
>
> On 06/02, GONG, Ruiqi wrote:
> > All usage and the definition of `bpf_prog_free_linfo()` has been removed
> > in commit e16301fbe183 ("bpf: Simplify freeing logic in linfo and
> > jited_linfo"). Clean up its declaration in the header file.
> >
> > Signed-off-by: GONG, Ruiqi <[email protected]>
>

I'm actually having trouble applying this locally. Can you please
rebase against bpf-next/master and resend it? Also, please check
Signed-off-by's "<first> <last> <email>" order and spelling. Should it
be "Ruiqi Gong <...>"?


> Acked-by: Stanislav Fomichev <[email protected]>
>
> > ---
> > include/linux/filter.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/include/linux/filter.h b/include/linux/filter.h
> > index bbce89937fde..f69114083ec7 100644
> > --- a/include/linux/filter.h
> > +++ b/include/linux/filter.h
> > @@ -874,7 +874,6 @@ void bpf_prog_free(struct bpf_prog *fp);
> >
> > bool bpf_opcode_in_insntable(u8 code);
> >
> > -void bpf_prog_free_linfo(struct bpf_prog *prog);
> > void bpf_prog_fill_jited_linfo(struct bpf_prog *prog,
> > const u32 *insn_to_jit_off);
> > int bpf_prog_alloc_jited_linfo(struct bpf_prog *prog);
> > --
> > 2.25.1
> >