2023-06-04 05:09:42

by Kumar, Udit

Subject: [PATCH v3 5/5] arm64: dts: ti: k3-j7200-common-proc-board: Add uart pin mux in wkup_pmx0

Add uart pin mux of wkup domain into common board file.

Signed-off-by: Udit Kumar <[email protected]>
---
.../dts/ti/k3-j7200-common-proc-board.dts | 22 ++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
index e12d93f56c51..809d1c910015 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
@@ -79,6 +79,24 @@ vdd_sd_dv: gpio-regulator-TLV71033 {
};
};

+&wkup_pmx0 {
+ mcu_uart0_pins_default: mcu_uart0_pins_default {
+ pinctrl-single,pins = <
+ J721E_WKUP_IOPAD(0xf4, PIN_INPUT, 0) /* (D20) MCU_UART0_RXD */
+ J721E_WKUP_IOPAD(0xf0, PIN_OUTPUT, 0) /* (D19) MCU_UART0_TXD */
+ J721E_WKUP_IOPAD(0xf8, PIN_INPUT, 0) /* (E20) MCU_UART0_CTSn */
+ J721E_WKUP_IOPAD(0xfc, PIN_OUTPUT, 0) /* (E21) MCU_UART0_RTSn */
+ >;
+ };
+
+ wkup_uart0_pins_default: wkup_uart0_pins_default {
+ pinctrl-single,pins = <
+ J721E_WKUP_IOPAD(0xb0, PIN_INPUT, 0) /* (B14) WKUP_UART0_RXD */
+ J721E_WKUP_IOPAD(0xb4, PIN_OUTPUT, 0) /* (A14) WKUP_UART0_TXD */
+ >;
+ };
+};
+
&wkup_pmx2 {
mcu_cpsw_pins_default: mcu-cpsw-pins-default {
pinctrl-single,pins = <
@@ -157,7 +175,9 @@ &wkup_uart0 {

&mcu_uart0 {
status = "okay";
- /* Default pinmux */
+ pinctrl-names = "default";
+ pinctrl-0 = <&mcu_uart0_pins_default>;
+ clock-frequency = <96000000>;
};

&main_uart0 {
--
2.34.1

2023-06-06 12:17:57

by Nishanth Menon

Subject: Re: [PATCH v3 5/5] arm64: dts: ti: k3-j7200-common-proc-board: Add uart pin mux in wkup_pmx0

On 10:25-20230604, Udit Kumar wrote:
> Add uart pin mux of wkup domain into common board file.
>
> Signed-off-by: Udit Kumar <[email protected]>
> ---
> .../dts/ti/k3-j7200-common-proc-board.dts | 22 ++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> index e12d93f56c51..809d1c910015 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
> @@ -79,6 +79,24 @@ vdd_sd_dv: gpio-regulator-TLV71033 {
> };
> };
>
> +&wkup_pmx0 {
> + mcu_uart0_pins_default: mcu_uart0_pins_default {
> + pinctrl-single,pins = <
> + J721E_WKUP_IOPAD(0xf4, PIN_INPUT, 0) /* (D20) MCU_UART0_RXD */
> + J721E_WKUP_IOPAD(0xf0, PIN_OUTPUT, 0) /* (D19) MCU_UART0_TXD */
> + J721E_WKUP_IOPAD(0xf8, PIN_INPUT, 0) /* (E20) MCU_UART0_CTSn */
> + J721E_WKUP_IOPAD(0xfc, PIN_OUTPUT, 0) /* (E21) MCU_UART0_RTSn */
> + >;
> + };
> +
> + wkup_uart0_pins_default: wkup_uart0_pins_default {

Could you add the pins to wkup_uart0 node as well?

> + pinctrl-single,pins = <
> + J721E_WKUP_IOPAD(0xb0, PIN_INPUT, 0) /* (B14) WKUP_UART0_RXD */
> + J721E_WKUP_IOPAD(0xb4, PIN_OUTPUT, 0) /* (A14) WKUP_UART0_TXD */
> + >;
> + };
> +};

We are also missing pinmux for main_uart1 and main_uart2

> +
> &wkup_pmx2 {
> mcu_cpsw_pins_default: mcu-cpsw-pins-default {
> pinctrl-single,pins = <
> @@ -157,7 +175,9 @@ &wkup_uart0 {
>
> &mcu_uart0 {
> status = "okay";
> - /* Default pinmux */
> + pinctrl-names = "default";
> + pinctrl-0 = <&mcu_uart0_pins_default>;
> + clock-frequency = <96000000>;
> };
>
> &main_uart0 {
> --
> 2.34.1
>

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

2023-06-08 16:26:23

by Kumar, Udit

Subject: Re: [PATCH v3 5/5] arm64: dts: ti: k3-j7200-common-proc-board: Add uart pin mux in wkup_pmx0

Thanks Nishanth

On 6/6/2023 5:39 PM, Nishanth Menon wrote:
> On 10:25-20230604, Udit Kumar wrote:
>> Add uart pin mux of wkup domain into common board file.
>>
>> Signed-off-by: Udit Kumar <[email protected]>
>> ---
>> .../dts/ti/k3-j7200-common-proc-board.dts | 22 ++++++++++++++++++-
>> 1 file changed, 21 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> index e12d93f56c51..809d1c910015 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> @@ -79,6 +79,24 @@ vdd_sd_dv: gpio-regulator-TLV71033 {
>> };
>> };
>>
>> [..]
> Could you add the pins to wkup_uart0 node as well?
>
>> + pinctrl-single,pins = <
>> + J721E_WKUP_IOPAD(0xb0, PIN_INPUT, 0) /* (B14) WKUP_UART0_RXD */
>> + J721E_WKUP_IOPAD(0xb4, PIN_OUTPUT, 0) /* (A14) WKUP_UART0_TXD */
>> + >;
>> + };
>> +};
> We are also missing pinmux for main_uart1 and main_uart2


I will address missing pin mux in next version

> [..]