Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0
("net/pppoe: make number of hash bits configurable") actually defined
config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick
typo with the numbers.
Fix the typo and define PPPOE_HASH_BITS_1.
Fixes: 96ba44c637b0 ("net/pppoe: make number of hash bits configurable")
Signed-off-by: Lukas Bulwahn <[email protected]>
---
drivers/net/ppp/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ppp/Kconfig b/drivers/net/ppp/Kconfig
index 2fbcae31fc02..8c9ed1889d1a 100644
--- a/drivers/net/ppp/Kconfig
+++ b/drivers/net/ppp/Kconfig
@@ -141,7 +141,7 @@ choice
This hash table is on a per outer ethernet interface.
-config PPPOE_HASH_BITS_2
+config PPPOE_HASH_BITS_1
bool "1 bit (2 buckets)"
config PPPOE_HASH_BITS_2
--
2.17.1
On Mon, Jun 05, 2023 at 09:27:43AM +0200, Lukas Bulwahn wrote:
> Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0
> ("net/pppoe: make number of hash bits configurable") actually defined
> config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick
> typo with the numbers.
>
> Fix the typo and define PPPOE_HASH_BITS_1.
>
> Fixes: 96ba44c637b0 ("net/pppoe: make number of hash bits configurable")
> Signed-off-by: Lukas Bulwahn <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
On 2023/06/05 14:16, Simon Horman wrote:
> On Mon, Jun 05, 2023 at 09:27:43AM +0200, Lukas Bulwahn wrote:
>> Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0
>> ("net/pppoe: make number of hash bits configurable") actually defined
>> config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick
>> typo with the numbers.
>>
>> Fix the typo and define PPPOE_HASH_BITS_1.
>>
>> Fixes: 96ba44c637b0 ("net/pppoe: make number of hash bits configurable")
>> Signed-off-by: Lukas Bulwahn <[email protected]>
> Reviewed-by: Simon Horman <[email protected]>
>
Reviewed-by: Jaco Kroon <[email protected]>
Sorry about that, that was indeed blonde. Thanks for the fixup.
Kind Regards,
Jaco
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <[email protected]>:
On Mon, 5 Jun 2023 09:27:43 +0200 you wrote:
> Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0
> ("net/pppoe: make number of hash bits configurable") actually defined
> config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick
> typo with the numbers.
>
> Fix the typo and define PPPOE_HASH_BITS_1.
>
> [...]
Here is the summary with links:
- net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition
https://git.kernel.org/netdev/net-next/c/ae91f7e436f8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html