2023-06-05 11:27:37

by Arnd Bergmann

Subject: [PATCH] gpio: delay: add OF_GPIO dependency

From: Arnd Bergmann <[email protected]>

The new driver fails to build when OF_GPIO is disabled:

drivers/gpio/gpio-delay.c: In function 'gpio_delay_of_xlate':
drivers/gpio/gpio-delay.c:79:39: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'

Fixes: cf5dec80c4e23 ("gpio: Add gpio delay driver")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/gpio/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index a1dac1345f60f..006abaedcae82 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1735,6 +1735,7 @@ config GPIO_AGGREGATOR

config GPIO_DELAY
tristate "GPIO delay"
+ depends on OF_GPIO
help
Say yes here to enable the GPIO delay, which provides a way to
configure platform specific delays for GPIO ramp-up or ramp-down
--
2.39.2

2023-06-05 14:58:33

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: delay: add OF_GPIO dependency

On Mon, Jun 5, 2023 at 1:02 PM Arnd Bergmann <[email protected]> wrote:
>
> From: Arnd Bergmann <[email protected]>
>
> The new driver fails to build when OF_GPIO is disabled:
>
> drivers/gpio/gpio-delay.c: In function 'gpio_delay_of_xlate':
> drivers/gpio/gpio-delay.c:79:39: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
>
> Fixes: cf5dec80c4e23 ("gpio: Add gpio delay driver")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index a1dac1345f60f..006abaedcae82 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1735,6 +1735,7 @@ config GPIO_AGGREGATOR
>
> config GPIO_DELAY
> tristate "GPIO delay"
> + depends on OF_GPIO
> help
> Say yes here to enable the GPIO delay, which provides a way to
> configure platform specific delays for GPIO ramp-up or ramp-down
> --
> 2.39.2
>

Thanks, Alexander beat you to it.

Bart