2023-06-08 08:46:24

by Christian Brauner

[permalink] [raw]
Subject: Re: [PATCH] scripts/gdb: Fix SB_* constants parsing

On Wed, Jun 07, 2023 at 03:13:35PM -0700, Florian Fainelli wrote:
> After f15afbd34d8f ("fs: fix undefined behavior in bit shift for
> SB_NOUSER") the constants were changed from plain integers which
> LX_VALUE() can parse to constants using the BIT() macro which causes the
> following:
>
> Reading symbols from build/linux-custom/vmlinux...done.
> Traceback (most recent call last):
> File "/home/fainelli/work/buildroot/output/arm64/build/linux-custom/vmlinux-gdb.py", line 25, in <module>
> import linux.constants
> File "/home/fainelli/work/buildroot/output/arm64/build/linux-custom/scripts/gdb/linux/constants.py", line 5
> LX_SB_RDONLY = ((((1UL))) << (0))
>
> Use LX_GDBPARSED() which does not suffer from that issue.
>
> f15afbd34d8f ("fs: fix undefined behavior in bit shift for SB_NOUSER")
> Signed-off-by: Florian Fainelli <[email protected]>
> ---

Fine by me,
Acked-by: Christian Brauner <[email protected]>