2023-05-31 02:20:54

by Yang Li

Subject: [PATCH -next] leds: cht-wcove: Fix an unsigned comparison which can never be negative

The return value from the call to cht_wc_leds_find_freq() is int.
However, the return value is being assigned to an unsigned
int variable 'ctrl', so making it an int.

Eliminate the following warning:
drivers/leds/leds-cht-wcove.c:236 cht_wc_leds_set_effect() warn: unsigned 'ctrl' is never less than zero.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5341
Signed-off-by: Yang Li <[email protected]>
---
drivers/leds/leds-cht-wcove.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-cht-wcove.c
index 0cfebee98910..10afd03164b4 100644
--- a/drivers/leds/leds-cht-wcove.c
+++ b/drivers/leds/leds-cht-wcove.c
@@ -223,8 +223,7 @@ static int cht_wc_leds_set_effect(struct led_classdev *cdev,
u8 effect)
{
struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev);
- unsigned int ctrl;
- int ret;
+ int ctrl, ret;

mutex_lock(&led->mutex);

--
2.20.1.7.g153144c

2023-06-08 16:39:54

by Lee Jones

Subject: Re: [PATCH -next] leds: cht-wcove: Fix an unsigned comparison which can never be negative

On Wed, 31 May 2023, Yang Li wrote:

> The return value from the call to cht_wc_leds_find_freq() is int.
> However, the return value is being assigned to an unsigned
> int variable 'ctrl', so making it an int.
>
> Eliminate the following warning:
> drivers/leds/leds-cht-wcove.c:236 cht_wc_leds_set_effect() warn: unsigned 'ctrl' is never less than zero.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5341
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/leds/leds-cht-wcove.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]