2023-06-09 12:30:46

by Min-Hua Chen

Subject: [PATCH] gpio: davinci: make davinci_gpio_dev_pm_ops static

This patch fixes the following sprse warnings:

drivers/gpio/gpio-davinci.c:695:1: sparse: warning: symbol 'davinci_gpio_dev_pm_ops' was not declared. Should it be static?

No functional change intended.

Signed-off-by: Min-Hua Chen <[email protected]>
---
drivers/gpio/gpio-davinci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index aaaf61dc2632..1aed3ace0240 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -692,7 +692,7 @@ static int davinci_gpio_resume(struct device *dev)
return 0;
}

-DEFINE_SIMPLE_DEV_PM_OPS(davinci_gpio_dev_pm_ops, davinci_gpio_suspend,
+static DEFINE_SIMPLE_DEV_PM_OPS(davinci_gpio_dev_pm_ops, davinci_gpio_suspend,
davinci_gpio_resume);

static const struct of_device_id davinci_gpio_ids[] = {
--
2.34.1

2023-06-13 09:59:18

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: davinci: make davinci_gpio_dev_pm_ops static

On Fri, Jun 9, 2023 at 2:16 PM Min-Hua Chen <[email protected]> wrote:
>
> This patch fixes the following sprse warnings:
>
> drivers/gpio/gpio-davinci.c:695:1: sparse: warning: symbol 'davinci_gpio_dev_pm_ops' was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Min-Hua Chen <[email protected]>
> ---
> drivers/gpio/gpio-davinci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index aaaf61dc2632..1aed3ace0240 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -692,7 +692,7 @@ static int davinci_gpio_resume(struct device *dev)
> return 0;
> }
>
> -DEFINE_SIMPLE_DEV_PM_OPS(davinci_gpio_dev_pm_ops, davinci_gpio_suspend,
> +static DEFINE_SIMPLE_DEV_PM_OPS(davinci_gpio_dev_pm_ops, davinci_gpio_suspend,
> davinci_gpio_resume);
>
> static const struct of_device_id davinci_gpio_ids[] = {
> --
> 2.34.1
>

Applied, thanks!

Bart