From: Mario Limonciello <[email protected]>
The Kconfig currently defaults the governor to schedutil on x86_64
only when intel-pstate and SMP have been selected.
If the kernel is built only with amd-pstate, the default governor
should also be schedutil.
Cc: Sun Peng (Leo) Li <[email protected]>
Signed-off-by: Mario Limonciello <[email protected]>
Reviewed-by: Leo Li <[email protected]>
Acked-by: Huang Rui <[email protected]>
Tested-by: Perry Yuan <[email protected]>
---
drivers/cpufreq/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index 2c839bd2b051..a1c51abddbc5 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -38,7 +38,7 @@ choice
prompt "Default CPUFreq governor"
default CPU_FREQ_DEFAULT_GOV_USERSPACE if ARM_SA1110_CPUFREQ
default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
- default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE && SMP
+ default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if (X86_INTEL_PSTATE || X86_AMD_PSTATE) && SMP
default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
help
This option sets which CPUFreq governor shall be loaded at
--
2.34.1
On 11-06-23, 23:03, Perry Yuan wrote:
> From: Mario Limonciello <[email protected]>
>
> The Kconfig currently defaults the governor to schedutil on x86_64
> only when intel-pstate and SMP have been selected.
>
> If the kernel is built only with amd-pstate, the default governor
> should also be schedutil.
>
> Cc: Sun Peng (Leo) Li <[email protected]>
> Signed-off-by: Mario Limonciello <[email protected]>
> Reviewed-by: Leo Li <[email protected]>
> Acked-by: Huang Rui <[email protected]>
> Tested-by: Perry Yuan <[email protected]>
> ---
> drivers/cpufreq/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 2c839bd2b051..a1c51abddbc5 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -38,7 +38,7 @@ choice
> prompt "Default CPUFreq governor"
> default CPU_FREQ_DEFAULT_GOV_USERSPACE if ARM_SA1110_CPUFREQ
> default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
> - default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE && SMP
> + default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if (X86_INTEL_PSTATE || X86_AMD_PSTATE) && SMP
> default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
> help
> This option sets which CPUFreq governor shall be loaded at
Acked-by: Viresh Kumar <[email protected]>
--
viresh
[AMD Official Use Only - General]
Hi Viresh.
> -----Original Message-----
> From: Viresh Kumar <[email protected]>
> Sent: Monday, June 12, 2023 3:26 PM
> To: Yuan, Perry <[email protected]>
> Cc: [email protected]; Huang, Ray <[email protected]>;
> Limonciello, Mario <[email protected]>; Sharma, Deepak
> <[email protected]>; Karny, Wyes <[email protected]>;
> Shenoy, Gautham Ranjal <[email protected]>; Li, Sun peng (Leo)
> <[email protected]>; Huang, Shimmer <[email protected]>;
> Du, Xiaojian <[email protected]>; Meng, Li (Jassmine)
> <[email protected]>; [email protected]; linux-
> [email protected]
> Subject: Re: [PATCH v2] cpufreq: amd-pstate: Set default governor to
> schedutil
>
> On 11-06-23, 23:03, Perry Yuan wrote:
> > From: Mario Limonciello <[email protected]>
> >
> > The Kconfig currently defaults the governor to schedutil on x86_64
> > only when intel-pstate and SMP have been selected.
> >
> > If the kernel is built only with amd-pstate, the default governor
> > should also be schedutil.
> >
> > Cc: Sun Peng (Leo) Li <[email protected]>
> > Signed-off-by: Mario Limonciello <[email protected]>
> > Reviewed-by: Leo Li <[email protected]>
> > Acked-by: Huang Rui <[email protected]>
> > Tested-by: Perry Yuan <[email protected]>
> > ---
> > drivers/cpufreq/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index
> > 2c839bd2b051..a1c51abddbc5 100644
> > --- a/drivers/cpufreq/Kconfig
> > +++ b/drivers/cpufreq/Kconfig
> > @@ -38,7 +38,7 @@ choice
> > prompt "Default CPUFreq governor"
> > default CPU_FREQ_DEFAULT_GOV_USERSPACE if
> ARM_SA1110_CPUFREQ
> > default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
> > - default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE
> && SMP
> > + default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if
> (X86_INTEL_PSTATE ||
> > +X86_AMD_PSTATE) && SMP
> > default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
> > help
> > This option sets which CPUFreq governor shall be loaded at
>
> Acked-by: Viresh Kumar <[email protected]>
>
> --
> Viresh
Thank you help to provide the ack flag.
I have added it to the V3.
Perry.
On 12-06-23, 16:11, Yuan, Perry wrote:
> Thank you help to provide the ack flag.
> I have added it to the V3.
Normally you aren't required to resend a patch just to add a tag. The maintainer
can pick those while applying the patch. Of course, if you are required to
update the patch and resend, then you must include all the provided tags by
yourself.
--
viresh
[AMD Official Use Only - General]
Hi Viresh,
> -----Original Message-----
> From: Viresh Kumar <[email protected]>
> Sent: Tuesday, June 13, 2023 12:06 PM
> To: Yuan, Perry <[email protected]>
> Cc: [email protected]; Huang, Ray <[email protected]>;
> Limonciello, Mario <[email protected]>; Sharma, Deepak
> <[email protected]>; Karny, Wyes <[email protected]>;
> Shenoy, Gautham Ranjal <[email protected]>; Li, Sun peng (Leo)
> <[email protected]>; Huang, Shimmer <[email protected]>;
> Du, Xiaojian <[email protected]>; Meng, Li (Jassmine)
> <[email protected]>; [email protected]; linux-
> [email protected]
> Subject: Re: [PATCH v2] cpufreq: amd-pstate: Set default governor to
> schedutil
>
> On 12-06-23, 16:11, Yuan, Perry wrote:
> > Thank you help to provide the ack flag.
> > I have added it to the V3.
>
> Normally you aren't required to resend a patch just to add a tag. The
> maintainer can pick those while applying the patch. Of course, if you are
> required to update the patch and resend, then you must include all the
> provided tags by yourself.
>
> --
> Viresh
Thank you help to tell me this.
I have added all the tags this time. ????
Perry,
On Mon, Jun 12, 2023 at 5:04 AM Perry Yuan <[email protected]> wrote:
>
> From: Mario Limonciello <[email protected]>
>
> The Kconfig currently defaults the governor to schedutil on x86_64
> only when intel-pstate and SMP have been selected.
>
> If the kernel is built only with amd-pstate, the default governor
> should also be schedutil.
>
> Cc: Sun Peng (Leo) Li <[email protected]>
> Signed-off-by: Mario Limonciello <[email protected]>
> Reviewed-by: Leo Li <[email protected]>
> Acked-by: Huang Rui <[email protected]>
> Tested-by: Perry Yuan <[email protected]>
> ---
> drivers/cpufreq/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 2c839bd2b051..a1c51abddbc5 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -38,7 +38,7 @@ choice
> prompt "Default CPUFreq governor"
> default CPU_FREQ_DEFAULT_GOV_USERSPACE if ARM_SA1110_CPUFREQ
> default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
> - default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE && SMP
> + default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if (X86_INTEL_PSTATE || X86_AMD_PSTATE) && SMP
> default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
> help
> This option sets which CPUFreq governor shall be loaded at
> --
Applied as 6.5 material, thanks!