2023-06-12 12:38:23

by Markus Burri

Subject: [PATCH v1] iio: ado: ad7192: Add error check and more debug log

Print read and expected device ID as debug warning.
Add error check for sd_sd_init() result.

Signed-off-by: Markus Burri <[email protected]>
---
drivers/iio/adc/ad7192.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
index d71977b..220c3b7 100644
--- a/drivers/iio/adc/ad7192.c
+++ b/drivers/iio/adc/ad7192.c
@@ -403,8 +403,8 @@ static int ad7192_setup(struct ad7192_state *st, struct device_node *np)
id &= AD7192_ID_MASK;

if (id != st->chip_info->chip_id)
- dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n",
- id);
+ dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X != 0x%X)\n",
+ id, st->chip_info->chip_id);

st->mode = AD7192_MODE_SEL(AD7192_MODE_IDLE) |
AD7192_MODE_CLKSRC(st->clock_sel) |
@@ -1049,7 +1049,9 @@ static int ad7192_probe(struct spi_device *spi)
else
indio_dev->info = &ad7192_info;

- ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
+ ret = ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
+ if (ret)
+ return ret;

ret = devm_ad_sd_setup_buffer_and_trigger(&spi->dev, indio_dev);
if (ret)
--
2.39.2

2023-06-12 20:00:23

by Andy Shevchenko

Subject: Re: [PATCH v1] iio: ado: ad7192: Add error check and more debug log

Mon, Jun 12, 2023 at 02:15:54PM +0200, Markus Burri kirjoitti:
> Print read and expected device ID as debug warning.
> Add error check for sd_sd_init() result.

sd_sd_...?

--
With Best Regards,
Andy Shevchenko