2023-06-13 06:47:02

by Markus Burri

Subject: [PATCH v1] iio: ado: ad7192: Add error check and more debug log

Print read and expected device ID as debug warning.
Add error check for ad_sd_init() result.

Signed-off-by: Markus Burri <[email protected]>
---
drivers/iio/adc/ad7192.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
index d71977b..220c3b7 100644
--- a/drivers/iio/adc/ad7192.c
+++ b/drivers/iio/adc/ad7192.c
@@ -403,8 +403,8 @@ static int ad7192_setup(struct ad7192_state *st, struct device_node *np)
id &= AD7192_ID_MASK;

if (id != st->chip_info->chip_id)
- dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n",
- id);
+ dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X != 0x%X)\n",
+ id, st->chip_info->chip_id);

st->mode = AD7192_MODE_SEL(AD7192_MODE_IDLE) |
AD7192_MODE_CLKSRC(st->clock_sel) |
@@ -1049,7 +1049,9 @@ static int ad7192_probe(struct spi_device *spi)
else
indio_dev->info = &ad7192_info;

- ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
+ ret = ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
+ if (ret)
+ return ret;

ret = devm_ad_sd_setup_buffer_and_trigger(&spi->dev, indio_dev);
if (ret)
--
2.39.2

2023-06-13 09:03:24

by Nuno Sá

Subject: Re: [PATCH v1] iio: ado: ad7192: Add error check and more debug log

On Tue, 2023-06-13 at 07:42 +0200, Markus Burri wrote:
> Print read and expected device ID as debug warning.
> Add error check for ad_sd_init() result.
>
> Signed-off-by: Markus Burri <[email protected]>
> ---

You have unrelated changes but they are easy enough to go in same patch
(at least for me). Hence:

Reviewed-by: Nuno Sa <[email protected]>

>  drivers/iio/adc/ad7192.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> index d71977b..220c3b7 100644
> --- a/drivers/iio/adc/ad7192.c
> +++ b/drivers/iio/adc/ad7192.c
> @@ -403,8 +403,8 @@ static int ad7192_setup(struct ad7192_state *st, struct
> device_node *np)
>         id &= AD7192_ID_MASK;
>  
>         if (id != st->chip_info->chip_id)
> -               dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n",
> -                        id);
> +               dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X !=
> 0x%X)\n",
> +                        id, st->chip_info->chip_id);
>  
>         st->mode = AD7192_MODE_SEL(AD7192_MODE_IDLE) |
>                 AD7192_MODE_CLKSRC(st->clock_sel) |
> @@ -1049,7 +1049,9 @@ static int ad7192_probe(struct spi_device *spi)
>         else
>                 indio_dev->info = &ad7192_info;
>  
> -       ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
> +       ret = ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info);
> +       if (ret)
> +               return ret;
>  
>         ret = devm_ad_sd_setup_buffer_and_trigger(&spi->dev, indio_dev);
>         if (ret)

2023-06-13 09:21:26

by Nuno Sá

Subject: Re: [PATCH v1] iio: ado: ad7192: Add error check and more debug log

On Tue, 2023-06-13 at 10:19 +0200, Nuno Sá wrote:
> On Tue, 2023-06-13 at 07:42 +0200, Markus Burri wrote:
> > Print read and expected device ID as debug warning.
> > Add error check for ad_sd_init() result.
> >
> > Signed-off-by: Markus Burri <[email protected]>
> > ---
>
> You have unrelated changes but they are easy enough to go in same patch
> (at least for me). Hence:
>

Actually, consider my tag valid after fixing the typo you have in the commit
message...

> Reviewed-by: Nuno Sa <[email protected]>
>
>

2023-06-14 07:49:35

by Jonathan Cameron

Subject: Re: [PATCH v1] iio: ado: ad7192: Add error check and more debug log

On Tue, 13 Jun 2023 10:46:30 +0200
Nuno Sá <[email protected]> wrote:

> On Tue, 2023-06-13 at 10:19 +0200, Nuno Sá wrote:
> > On Tue, 2023-06-13 at 07:42 +0200, Markus Burri wrote:
> > > Print read and expected device ID as debug warning.
> > > Add error check for ad_sd_init() result.
> > >
> > > Signed-off-by: Markus Burri <[email protected]>
> > > ---
> >
> > You have unrelated changes but they are easy enough to go in same patch
> > (at least for me). Hence:
> >
>
> Actually, consider my tag valid after fixing the typo you have in the commit
> message...
>
This is also v2... So patch title should reflect that.
(well v3 for next version with the typo fixed)


> > Reviewed-by: Nuno Sa <[email protected]>
> >
> >
>