2023-06-12 03:16:21

by Li zeming

Subject: [PATCH] time: clocksource-wdtest: Remove unnecessary initialization of variable 'ret'

ret is assigned first, so it does not need to initialize the assignment.

Signed-off-by: Li zeming <[email protected]>
---
kernel/time/clocksource-wdtest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/clocksource-wdtest.c b/kernel/time/clocksource-wdtest.c
index df922f49d171..bf89700aa9bf 100644
--- a/kernel/time/clocksource-wdtest.c
+++ b/kernel/time/clocksource-wdtest.c
@@ -181,7 +181,7 @@ static void clocksource_wdtest_cleanup(void)

static int __init clocksource_wdtest_init(void)
{
- int ret = 0;
+ int ret;

wdtest_print_module_parms();

--
2.18.2

2023-06-12 07:51:20

by Thomas Gleixner

Subject: Re: [PATCH] time: clocksource-wdtest: Remove unnecessary initialization of variable 'ret'

Li!

On Wed, Jun 14 2023 at 03:35, Li zeming wrote:

Can you please pick the proper prefixes and not create random ones.

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject

> ret is assigned first, so it does not need to initialize the
> assignment.

This sentence does not make sense. You cannot initialize an
assignment. What you want to say is something like this.

'ret' is always assigned before being checked, so initializing the
variable is not required.

No?

Thanks,

tglx