Struct bd6107_platform_data refers to a platform device within
the Linux device hierarchy. The test in bd6107_backlight_check_fb()
compares it against the fbdev device in struct fb_info.dev, which
is different. Fix the test by comparing to struct fb_info.device.
Fixes a bug in the backlight driver and prepares fbdev for making
struct fb_info.dev optional.
v2:
* move renames into separate patch (Javier, Sam, Michael)
Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver")
Signed-off-by: Thomas Zimmermann <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Lee Jones <[email protected]>
Cc: Daniel Thompson <[email protected]>
Cc: Jingoo Han <[email protected]>
Cc: [email protected]
Cc: <[email protected]> # v3.12+
Reviewed-by: Javier Martinez Canillas <[email protected]>
Reviewed-by: Sam Ravnborg <[email protected]>
Reviewed-by: Daniel Thompson <[email protected]>
---
drivers/video/backlight/bd6107.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/bd6107.c b/drivers/video/backlight/bd6107.c
index f4db6c064635b..e3410444ea235 100644
--- a/drivers/video/backlight/bd6107.c
+++ b/drivers/video/backlight/bd6107.c
@@ -104,7 +104,7 @@ static int bd6107_backlight_check_fb(struct backlight_device *backlight,
{
struct bd6107 *bd = bl_get_data(backlight);
- return bd->pdata->fbdev == NULL || bd->pdata->fbdev == info->dev;
+ return bd->pdata->fbdev == NULL || bd->pdata->fbdev == info->device;
}
static const struct backlight_ops bd6107_backlight_ops = {
--
2.41.0
Hi
Am 14.06.23 um 15:51 schrieb Lee Jones:
> On Tue, 13 Jun 2023, Thomas Zimmermann wrote:
>
>> Struct bd6107_platform_data refers to a platform device within
>> the Linux device hierarchy. The test in bd6107_backlight_check_fb()
>> compares it against the fbdev device in struct fb_info.dev, which
>> is different. Fix the test by comparing to struct fb_info.device.
>>
>> Fixes a bug in the backlight driver and prepares fbdev for making
>> struct fb_info.dev optional.
>>
>> v2:
>> * move renames into separate patch (Javier, Sam, Michael)
>>
>> Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver")
>> Signed-off-by: Thomas Zimmermann <[email protected]>
>> Cc: Laurent Pinchart <[email protected]>
>> Cc: Lee Jones <[email protected]>
>> Cc: Daniel Thompson <[email protected]>
>> Cc: Jingoo Han <[email protected]>
>> Cc: [email protected]
>> Cc: <[email protected]> # v3.12+
>> Reviewed-by: Javier Martinez Canillas <[email protected]>
>> Reviewed-by: Sam Ravnborg <[email protected]>
>> Reviewed-by: Daniel Thompson <[email protected]>
>> ---
>> drivers/video/backlight/bd6107.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Can the Backlight patches be applied without the others and visa versa?
Unfortunately not. The rest of the series requires the backlight patches.
Best regards
Thomas
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
On Tue, 13 Jun 2023, Thomas Zimmermann wrote:
> Struct bd6107_platform_data refers to a platform device within
> the Linux device hierarchy. The test in bd6107_backlight_check_fb()
> compares it against the fbdev device in struct fb_info.dev, which
> is different. Fix the test by comparing to struct fb_info.device.
>
> Fixes a bug in the backlight driver and prepares fbdev for making
> struct fb_info.dev optional.
>
> v2:
> * move renames into separate patch (Javier, Sam, Michael)
>
> Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver")
> Signed-off-by: Thomas Zimmermann <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Cc: Lee Jones <[email protected]>
> Cc: Daniel Thompson <[email protected]>
> Cc: Jingoo Han <[email protected]>
> Cc: [email protected]
> Cc: <[email protected]> # v3.12+
> Reviewed-by: Javier Martinez Canillas <[email protected]>
> Reviewed-by: Sam Ravnborg <[email protected]>
> Reviewed-by: Daniel Thompson <[email protected]>
> ---
> drivers/video/backlight/bd6107.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Can the Backlight patches be applied without the others and visa versa?
--
Lee Jones [李琼斯]
Hi Lee
Am 14.06.23 um 16:13 schrieb Thomas Zimmermann:
[...]
>> Can the Backlight patches be applied without the others and visa versa?
>
> Unfortunately not. The rest of the series requires the backlight patches.
Are you OK with the patches going through drm?
Best regards
Thomas
>
> Best regards
> Thomas
>
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
On Fri, 16 Jun 2023, Thomas Zimmermann wrote:
> Hi Lee
>
> Am 14.06.23 um 16:13 schrieb Thomas Zimmermann:
> [...]
> > > Can the Backlight patches be applied without the others and visa versa?
> >
> > Unfortunately not. The rest of the series requires the backlight patches.
>
> Are you OK with the patches going through drm?
Shouldn't be an issue.
Please ensure my Ack is added to each patch, even if you have to RESEND.
--
Lee Jones [李琼斯]
Am 19.06.23 um 10:31 schrieb Lee Jones:
> On Fri, 16 Jun 2023, Thomas Zimmermann wrote:
>
>> Hi Lee
>>
>> Am 14.06.23 um 16:13 schrieb Thomas Zimmermann:
>> [...]
>>>> Can the Backlight patches be applied without the others and visa versa?
>>>
>>> Unfortunately not. The rest of the series requires the backlight patches.
>>
>> Are you OK with the patches going through drm?
>
> Shouldn't be an issue.
>
> Please ensure my Ack is added to each patch, even if you have to RESEND.
>
Thank you so much.
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)