2023-06-16 12:40:28

by Juerg Haefliger

[permalink] [raw]
Subject: [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro

The module loads firmware so add a MODULE_FIRMWARE macro to provide that
information via modinfo.

Signed-off-by: Juerg Haefliger <[email protected]>
---
drivers/fsi/fsi-master-ast-cf.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
index 5f608ef8b53c..1316bfd121fe 100644
--- a/drivers/fsi/fsi-master-ast-cf.c
+++ b/drivers/fsi/fsi-master-ast-cf.c
@@ -1441,3 +1441,5 @@ static struct platform_driver fsi_master_acf = {

module_platform_driver(fsi_master_acf);
MODULE_LICENSE("GPL");
+
+MODULE_FIRMWARE(FW_FILE_NAME);
--
2.37.2



2023-06-28 08:29:55

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro

On Fri, Jun 16, 2023 at 02:20:40PM +0200, Juerg Haefliger wrote:
> The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> information via modinfo.
>
> Signed-off-by: Juerg Haefliger <[email protected]>
> ---
> drivers/fsi/fsi-master-ast-cf.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
> index 5f608ef8b53c..1316bfd121fe 100644
> --- a/drivers/fsi/fsi-master-ast-cf.c
> +++ b/drivers/fsi/fsi-master-ast-cf.c
> @@ -1441,3 +1441,5 @@ static struct platform_driver fsi_master_acf = {
>
> module_platform_driver(fsi_master_acf);
> MODULE_LICENSE("GPL");
> +
> +MODULE_FIRMWARE(FW_FILE_NAME);

No need for the extra blank line, right?

And what commit id does this fix?

thanks,

greg k-h

2023-06-28 08:36:55

by Juerg Haefliger

[permalink] [raw]
Subject: Re: [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro

On Wed, 28 Jun 2023 08:47:12 +0200
Greg KH <[email protected]> wrote:

> On Fri, Jun 16, 2023 at 02:20:40PM +0200, Juerg Haefliger wrote:
> > The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> > information via modinfo.
> >
> > Signed-off-by: Juerg Haefliger <[email protected]>
> > ---
> > drivers/fsi/fsi-master-ast-cf.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
> > index 5f608ef8b53c..1316bfd121fe 100644
> > --- a/drivers/fsi/fsi-master-ast-cf.c
> > +++ b/drivers/fsi/fsi-master-ast-cf.c
> > @@ -1441,3 +1441,5 @@ static struct platform_driver fsi_master_acf = {
> >
> > module_platform_driver(fsi_master_acf);
> > MODULE_LICENSE("GPL");
> > +
> > +MODULE_FIRMWARE(FW_FILE_NAME);
>
> No need for the extra blank line, right?

Guess not.


> And what commit id does this fix?

6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")

Want me to send a v2?

...Juerg



> thanks,
>
> greg k-h

Attachments:
(No filename) (849.00 B)
OpenPGP digital signature

2023-06-28 08:39:10

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro

On Wed, Jun 28, 2023 at 09:29:46AM +0200, Juerg Haefliger wrote:
> On Wed, 28 Jun 2023 08:47:12 +0200
> Greg KH <[email protected]> wrote:
>
> > On Fri, Jun 16, 2023 at 02:20:40PM +0200, Juerg Haefliger wrote:
> > > The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> > > information via modinfo.
> > >
> > > Signed-off-by: Juerg Haefliger <[email protected]>
> > > ---
> > > drivers/fsi/fsi-master-ast-cf.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
> > > index 5f608ef8b53c..1316bfd121fe 100644
> > > --- a/drivers/fsi/fsi-master-ast-cf.c
> > > +++ b/drivers/fsi/fsi-master-ast-cf.c
> > > @@ -1441,3 +1441,5 @@ static struct platform_driver fsi_master_acf = {
> > >
> > > module_platform_driver(fsi_master_acf);
> > > MODULE_LICENSE("GPL");
> > > +
> > > +MODULE_FIRMWARE(FW_FILE_NAME);
> >
> > No need for the extra blank line, right?
>
> Guess not.
>
>
> > And what commit id does this fix?
>
> 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")
>
> Want me to send a v2?

Please do and properly add the fixes line and the cc: stable line so
that it will get backported correctly.

thanks,

greg k-h

2023-06-28 10:08:09

by Juerg Haefliger

[permalink] [raw]
Subject: [PATCH v2] fsi: master-ast-cf: Add MODULE_FIRMWARE macro

The module loads firmware so add a MODULE_FIRMWARE macro to provide that
information via modinfo.

Fixes: 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")
Cc: [email protected] # 4.19+
Signed-off-by: Juerg Haefliger <[email protected]>

---
v2:
- Remove empty line
- Add Fixes and Cc tags
---
drivers/fsi/fsi-master-ast-cf.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
index 5f608ef8b53c..cde281ec89d7 100644
--- a/drivers/fsi/fsi-master-ast-cf.c
+++ b/drivers/fsi/fsi-master-ast-cf.c
@@ -1441,3 +1441,4 @@ static struct platform_driver fsi_master_acf = {

module_platform_driver(fsi_master_acf);
MODULE_LICENSE("GPL");
+MODULE_FIRMWARE(FW_FILE_NAME);
--
2.39.2