From: Francesco Dolcini <[email protected]>
This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
This fixes a regression in which the link would come up, but no
communication was possible.
The reverted commit was also removing a comment about
DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
since it seems that this is unrelated to the original code change.
Cc: Praneeth Bajjuri <[email protected]>
Closes: https://lore.kernel.org/all/[email protected]/
Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link")
Signed-off-by: Francesco Dolcini <[email protected]>
---
drivers/net/phy/dp83867.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 76f5a2402fb0..e397e7d642d9 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -936,7 +936,7 @@ static int dp83867_phy_reset(struct phy_device *phydev)
{
int err;
- err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESTART);
+ err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESET);
if (err < 0)
return err;
--
2.25.1
On Mon, Jun 19, 2023 at 05:44:35PM +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <[email protected]>
>
> This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
>
> This fixes a regression in which the link would come up, but no
> communication was possible.
>
> The reverted commit was also removing a comment about
> DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
> since it seems that this is unrelated to the original code change.
>
> Cc: Praneeth Bajjuri <[email protected]>
> Closes: https://lore.kernel.org/all/[email protected]/
> Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link")
> Signed-off-by: Francesco Dolcini <[email protected]>
There has been plenty of time given for somebody to investigate this
regression, and nothing has happened. So i agree, lets revert it.
Reviewed-by: Andrew Lunn <[email protected]>
Andrew
On 6/19/2023 11:30 AM, Andrew Lunn wrote:
> On Mon, Jun 19, 2023 at 05:44:35PM +0200, Francesco Dolcini wrote:
>> From: Francesco Dolcini <[email protected]>
>>
>> This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
>>
>> This fixes a regression in which the link would come up, but no
>> communication was possible.
>>
>> The reverted commit was also removing a comment about
>> DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
>> since it seems that this is unrelated to the original code change.
>>
>> Cc: Praneeth Bajjuri <[email protected]>
>> Closes: https://lore.kernel.org/all/[email protected]/
>> Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link")
>> Signed-off-by: Francesco Dolcini <[email protected]>
>
> There has been plenty of time given for somebody to investigate this
> regression, and nothing has happened. So i agree, lets revert it.
>
> Reviewed-by: Andrew Lunn <[email protected]>
Agreed to revert.
Reviewed-by: Praneeth Bajjuri <[email protected]>
>
> Andrew
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
On Mon, 19 Jun 2023 17:44:35 +0200 you wrote:
> From: Francesco Dolcini <[email protected]>
>
> This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
>
> This fixes a regression in which the link would come up, but no
> communication was possible.
>
> [...]
Here is the summary with links:
- [net,v1] Revert "net: phy: dp83867: perform soft reset and retain established link"
https://git.kernel.org/netdev/net/c/a129b41fe0a8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html