2023-06-20 07:16:07

by Huqiang Qin

Subject: [PATCH] dt-bindings: interrupt-controller: New binding for Meson-C3 SoCs

Update dt-binding document for GPIO interrupt controller of Meson-C3 SoCs

Signed-off-by: Huqiang Qin <[email protected]>
---
.../bindings/interrupt-controller/amlogic,meson-gpio-intc.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
index bde63f8f090e..fdea0488a98c 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
+++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
@@ -19,6 +19,7 @@ Required properties:
"amlogic,meson-sm1-gpio-intc" for SM1 SoCs (S905D3, S905X3, S905Y3)
"amlogic,meson-a1-gpio-intc" for A1 SoCs (A113L)
"amlogic,meson-s4-gpio-intc" for S4 SoCs (S802X2, S905Y4, S805X2G, S905W2)
+ "amlogic,meson-c3-gpio-intc" for C3 SoCs (C308L, C302X)
- reg : Specifies base physical address and size of the registers.
- interrupt-controller : Identifies the node as an interrupt controller.
- #interrupt-cells : Specifies the number of cells needed to encode an
--
2.37.1

2023-06-20 07:42:03

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: interrupt-controller: New binding for Meson-C3 SoCs

On 20/06/2023 09:08, Huqiang Qin wrote:
> Update dt-binding document for GPIO interrupt controller of Meson-C3 SoCs
>
> Signed-off-by: Huqiang Qin <[email protected]>
> ---
> .../bindings/interrupt-controller/amlogic,meson-gpio-intc.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
> index bde63f8f090e..fdea0488a98c 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
> @@ -19,6 +19,7 @@ Required properties:
> "amlogic,meson-sm1-gpio-intc" for SM1 SoCs (S905D3, S905X3, S905Y3)
> "amlogic,meson-a1-gpio-intc" for A1 SoCs (A113L)
> "amlogic,meson-s4-gpio-intc" for S4 SoCs (S802X2, S905Y4, S805X2G, S905W2)
> + "amlogic,meson-c3-gpio-intc" for C3 SoCs (C308L, C302X)

Where is the user?

If there is going to be resend/new version:
A nit, subject: drop second/last, redundant "New binding for". The
"dt-bindings" prefix is already stating that these are bindings.
"Add Meson C3 SoC interrupt controller"

Best regards,
Krzysztof

2023-06-27 08:30:47

by Neil Armstrong

Subject: Re: [PATCH] dt-bindings: interrupt-controller: New binding for Meson-C3 SoCs

On 20/06/2023 09:34, Krzysztof Kozlowski wrote:
> On 20/06/2023 09:08, Huqiang Qin wrote:
>> Update dt-binding document for GPIO interrupt controller of Meson-C3 SoCs
>>
>> Signed-off-by: Huqiang Qin <[email protected]>
>> ---
>> .../bindings/interrupt-controller/amlogic,meson-gpio-intc.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
>> index bde63f8f090e..fdea0488a98c 100644
>> --- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
>> @@ -19,6 +19,7 @@ Required properties:
>> "amlogic,meson-sm1-gpio-intc" for SM1 SoCs (S905D3, S905X3, S905Y3)
>> "amlogic,meson-a1-gpio-intc" for A1 SoCs (A113L)
>> "amlogic,meson-s4-gpio-intc" for S4 SoCs (S802X2, S905Y4, S805X2G, S905W2)
>> + "amlogic,meson-c3-gpio-intc" for C3 SoCs (C308L, C302X)
>
> Where is the user?
>
> If there is going to be resend/new version:
> A nit, subject: drop second/last, redundant "New binding for". The
> "dt-bindings" prefix is already stating that these are bindings.
> "Add Meson C3 SoC interrupt controller"

And the bindings was updated to yaml and merged for v6.5, please rebase on:
https://lore.kernel.org/all/[email protected]/

Neil

>
> Best regards,
> Krzysztof
>